Alecb/generation api upgrade preannounce #26249

alec-baird · 2024-10-09T03:57:48Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2024-10-09T03:57:51Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

⚠️Az.DesktopVirtualization

️✔️Build

️✔️PowerShell Core - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

⚠️Signature Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzWvdApplication Get-AzWvdApplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdApplication Get-AzWvdApplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdApplicationGroup Get-AzWvdApplicationGroup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdApplicationGroup Get-AzWvdApplicationGroup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdDesktop Get-AzWvdDesktop Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdDesktop Get-AzWvdDesktop changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdHostPool Get-AzWvdHostPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdHostPool Get-AzWvdHostPool changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdMsixPackage Get-AzWvdMsixPackage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdMsixPackage Get-AzWvdMsixPackage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdPrivateEndpointConnection Get-AzWvdPrivateEndpointConnection Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdPrivateEndpointConnection Get-AzWvdPrivateEndpointConnection changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdPrivateLinkResource Get-AzWvdPrivateLinkResource Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdPrivateLinkResource Get-AzWvdPrivateLinkResource changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdRegistrationInfo Get-AzWvdRegistrationInfo Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdRegistrationInfo Get-AzWvdRegistrationInfo changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdScalingPlan Get-AzWvdScalingPlan Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdScalingPlan Get-AzWvdScalingPlan changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdScalingPlanPersonalSchedule Get-AzWvdScalingPlanPersonalSchedule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdScalingPlanPersonalSchedule Get-AzWvdScalingPlanPersonalSchedule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdScalingPlanPooledSchedule Get-AzWvdScalingPlanPooledSchedule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdScalingPlanPooledSchedule Get-AzWvdScalingPlanPooledSchedule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdSessionHost Get-AzWvdSessionHost Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdSessionHost Get-AzWvdSessionHost changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdStartMenuItem Get-AzWvdStartMenuItem Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdStartMenuItem Get-AzWvdStartMenuItem changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdUserSession Get-AzWvdUserSession Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdUserSession Get-AzWvdUserSession changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzWvdWorkspace Get-AzWvdWorkspace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzWvdWorkspace Get-AzWvdWorkspace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

️✔️Test

️✔️PowerShell Core - Linux

️✔️PowerShell Core - MacOS

️✔️PowerShell Core - Windows

src/DesktopVirtualization/DesktopVirtualization.Autorest/README.md

documentation/breaking-changes/upcoming-breaking-changes.md

github-actions · 2024-10-09T19:07:03Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Co-authored-by: Jin Lei <[email protected]>

…b.com/AVD-RDDAM/avd-rddam-azure-powershell into alecb/generationAPIUpgradePreannounce

msJinLei

Please change the link in preannouncement to https://go.microsoft.com/fwlink/?linkid=2292409

src/DesktopVirtualization/DesktopVirtualization.Autorest/README.md

msJinLei · 2024-10-21T12:53:35Z

documentation/breaking-changes/upcoming-breaking-changes.md

@@ -25,5 +25,106 @@
    https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes/breaking-change-template.md
 -->

-# Upcoming Breaking Changes
+# Upcoming Breaking Changes of Az.DesktopVirtualization



Could you remove the file as the content is moved to the new PR #26269

msJinLei

Please remove the "upcoming-breaking-changes.md" and regenerate the module and commit all the necessary changes

msJinLei · 2024-10-21T12:58:43Z

Move breaking change announcement part in this PR to #26269

* Wrote preannouncement message * updated readme with cmdlet notices * Update documentation/breaking-changes/upcoming-breaking-changes.md Co-authored-by: Jin Lei <[email protected]> * Update documentation/breaking-changes/upcoming-breaking-changes.md Co-authored-by: Jin Lei <[email protected]> * Update documentation/breaking-changes/upcoming-breaking-changes.md Co-authored-by: Jin Lei <[email protected]> * Added specifics to Readme, preannouncement page * Replaced link with fwlink * removed upcoming-breakingchanges --------- Co-authored-by: Jin Lei <[email protected]>

* Alecb/generation api upgrade preannounce (#26249) * Wrote preannouncement message * updated readme with cmdlet notices * Update documentation/breaking-changes/upcoming-breaking-changes.md Co-authored-by: Jin Lei <[email protected]> * Update documentation/breaking-changes/upcoming-breaking-changes.md Co-authored-by: Jin Lei <[email protected]> * Update documentation/breaking-changes/upcoming-breaking-changes.md Co-authored-by: Jin Lei <[email protected]> * Added specifics to Readme, preannouncement page * Replaced link with fwlink * removed upcoming-breakingchanges --------- Co-authored-by: Jin Lei <[email protected]> * adapt --------- Co-authored-by: Alec Baird <[email protected]> Co-authored-by: Jin Lei <[email protected]>

alec-baird added 2 commits October 8, 2024 21:34

Wrote preannouncement message

9e608aa

updated readme with cmdlet notices

a1c0892

msJinLei requested changes Oct 9, 2024

View reviewed changes

msJinLei added the needs-revision label Oct 9, 2024

alec-baird and others added 5 commits October 9, 2024 13:17

Update documentation/breaking-changes/upcoming-breaking-changes.md

4e0b341

Co-authored-by: Jin Lei <[email protected]>

Update documentation/breaking-changes/upcoming-breaking-changes.md

10cfdc9

Co-authored-by: Jin Lei <[email protected]>

Update documentation/breaking-changes/upcoming-breaking-changes.md

d02f453

Co-authored-by: Jin Lei <[email protected]>

Added specifics to Readme, preannouncement page

c2fed2a

Merge branch 'alecb/generationAPIUpgradePreannounce' of https://githu…

99d1cfe

…b.com/AVD-RDDAM/avd-rddam-azure-powershell into alecb/generationAPIUpgradePreannounce

msJinLei mentioned this pull request Oct 10, 2024

Preannouncement of DesktopVirtualization Upcoming Breaking Changes #26269

Merged

6 tasks

msJinLei requested changes Oct 13, 2024

View reviewed changes

src/DesktopVirtualization/DesktopVirtualization.Autorest/README.md Outdated Show resolved Hide resolved

Replaced link with fwlink

0319010

msJinLei added the Breaking Change Preannounce This PR adds preannouncement about upcoming breaking change label Oct 21, 2024

msJinLei reviewed Oct 21, 2024

View reviewed changes

removed upcoming-breakingchanges

27aeb69

alec-baird requested a review from msJinLei October 21, 2024 20:51

alec-baird added needs-review and removed needs-revision labels Oct 21, 2024

msJinLei approved these changes Oct 22, 2024

View reviewed changes

msJinLei merged commit 3434950 into Azure:generation Oct 22, 2024
9 checks passed

msJinLei mentioned this pull request Oct 22, 2024

Restore upcoming-breaking-changes.md #26410

Merged

6 tasks

azure-pipelines bot mentioned this pull request Oct 22, 2024

Migrate DesktopVirtualization from generation to main #26413

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alecb/generation api upgrade preannounce #26249

Alecb/generation api upgrade preannounce #26249

alec-baird commented Oct 9, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024

msJinLei left a comment

msJinLei Oct 21, 2024

msJinLei left a comment

msJinLei commented Oct 21, 2024

Alecb/generation api upgrade preannounce #26249

Alecb/generation api upgrade preannounce #26249

Conversation

alec-baird commented Oct 9, 2024 • edited Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Oct 9, 2024 • edited Loading

github-actions bot commented Oct 9, 2024

msJinLei left a comment

Choose a reason for hiding this comment

msJinLei Oct 21, 2024

Choose a reason for hiding this comment

msJinLei left a comment

Choose a reason for hiding this comment

msJinLei commented Oct 21, 2024

alec-baird commented Oct 9, 2024 •

edited

Loading

azure-client-tools-bot-prd bot commented Oct 9, 2024 •

edited

Loading