Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module's dependency #17824

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

kceiw
Copy link
Contributor

@kceiw kceiw commented Apr 15, 2022

Description

There are a few changes in this PR.

  1. Make sure RequiredModules are automatically installed when Az.Tools.Predictor is installed. This is done via clearing the ExternalModuleDependencies. We already set the RequiredModules. Setting ExternalModuleDependencies with the same content confuses PowerShell not to install RequiredModules automatically.
  2. Remove the ref assemblies in the output directory and the packages. One of the package we reference contains many assemblies in the content and those assemblies are copied to our output directory. Thus making our package unnecessarily large. We exclude those content files in the packages now.
  3. Update the our dependent packages to the stable version.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue dingmeng-xue changed the base branch from main to internal/predictor April 28, 2022 14:20
@dingmeng-xue dingmeng-xue merged commit a5d446a into Azure:internal/predictor Apr 28, 2022
wyunchi-ms pushed a commit that referenced this pull request Apr 29, 2022
* Fix module's dependency (#17824)

* Update the external dependenct modules

* update the packages to GA version

* Exclude contentFiles in the out directory

* Remove Az as the external dependent module

* Format the csproj file.

* update files

Co-authored-by: kceiw <[email protected]>
VeryEarly pushed a commit that referenced this pull request Sep 24, 2022
* Fix module's dependency (#17824)

* Update the external dependenct modules

* update the packages to GA version

* Exclude contentFiles in the out directory

* Remove Az as the external dependent module

* Format the csproj file.

* update files

* Release Az.Tools.Predictor 1.0.2

* Update Az.Tools.Predictor.csproj

* Update Az.Tools.Predictor.psd1

Co-authored-by: kceiw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants