Skip to content

Commit

Permalink
Fix module's dependency (#17824)
Browse files Browse the repository at this point in the history
* Update the external dependenct modules

* update the packages to GA version

* Exclude contentFiles in the out directory

* Remove Az as the external dependent module

* Format the csproj file.
  • Loading branch information
kceiw authored Apr 28, 2022
1 parent a8ac552 commit a5d446a
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<AssemblyName>Microsoft.Azure.PowerShell.Tools.AzPredictor</AssemblyName>
<RootNamespace>Microsoft.Azure.PowerShell.Tools.AzPredictor</RootNamespace>
<RepoArtifacts>$(MSBuildThisFileDirectory)</RepoArtifacts>
<OutputPath>$(RepoArtifacts)..\..\..\artifacts\Tools\Az.Tools.Predictor\</OutputPath>
<DisableTransitiveProjectReferences>true</DisableTransitiveProjectReferences>
<ProduceReferenceAssemblyInOutDir>false</ProduceReferenceAssemblyInOutDir>
</PropertyGroup>

<PropertyGroup>
Expand All @@ -19,10 +21,14 @@ For more information on Az Predictor, please visit the following: https://aka.ms
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.17.0" />
<PackageReference Include="Microsoft.ApplicationInsights" Version="2.18.0" />
<PackageReference Include="Microsoft.Azure.PowerShell.Common.Share" Version="1.3.45-preview" />
<PackageReference Include="Microsoft.PowerShell.SDK" Version="7.2.0-preview.6" />
<PackageReference Include="System.Management.Automation" Version="7.2.0-preview.6" />
<PackageReference Include="Microsoft.PowerShell.SDK" Version="7.2.0">
<ExcludeAssets>contentFiles</ExcludeAssets>
</PackageReference>
<PackageReference Include="System.Management.Automation" Version="7.2.0">
<ExcludeAssets>contentFiles</ExcludeAssets>
</PackageReference>
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
RootModule = 'Az.Tools.Predictor.psm1'

# Version number of this module.
ModuleVersion = '1.0.0'
ModuleVersion = '1.0.1'

# Supported PSEditions
CompatiblePSEditions = 'Core'
Expand Down Expand Up @@ -67,7 +67,7 @@ PrivateData = @{
# IconUri = ''

# ReleaseNotes of this module
ReleaseNotes = '* Updated dependency on PSReadline 2.2.2
ReleaseNotes = '* Updated dependency on PSReadline 2.2.2
* Updated dependency on PowerShell 7.2
* Added validation of pre-requisites before loading module'

Expand All @@ -78,7 +78,7 @@ PrivateData = @{
# RequireLicenseAcceptance = $false

# External dependent modules of this module
ExternalModuleDependencies = @('Az.Accounts', 'PSReadLine')
ExternalModuleDependencies = @()

} # End of PSData hashtable

Expand Down
2 changes: 1 addition & 1 deletion tools/Az.Tools.Predictor/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<TargetFramework>net6.0</TargetFramework>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<Version>1.0.0</Version>
<Version>1.0.1</Version>
<Authors>Microsoft Corporation</Authors>
<Company>Microsoft Corporation</Company>
<Copyright>Microsoft Corporation. All rights reserved.</Copyright>
Expand Down
Binary file not shown.
Binary file not shown.
5 changes: 3 additions & 2 deletions tools/Az.Tools.Predictor/MockPSConsole/MockPSConsole.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.PowerShell.SDK" Version="7.2.0-preview.6" />
<PackageReference Include="System.Management.Automation" Version="7.2.0-preview.6" />
<PackageReference Include="Microsoft.PowerShell.SDK" Version="7.2.0" />
<PackageReference Include="System.Management.Automation" Version="7.2.0" />
</ItemGroup>

<ItemGroup>
Expand All @@ -20,6 +20,7 @@

<ItemGroup>
<None Include="Microsoft.PowerShell.PSReadLine.Polyfiller.dll" CopyToOutputDirectory="PreserveNewest" />
<None Include="Microsoft.PowerShell.PSReadLine2.dll" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>

</Project>

0 comments on commit a5d446a

Please sign in to comment.