Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed identity fix. #3306

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Managed identity fix. #3306

merged 2 commits into from
Mar 13, 2023

Conversation

khkh-ms
Copy link
Contributor

@khkh-ms khkh-ms commented Mar 8, 2023 •
edited
Loading

Issue describing the changes in this PR

  • Fixing the bug > The consumption check should only be for Linux (not Windows)
  • Updated the error message

Resolves

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@khkh-ms khkh-ms requested a review from patelchandni March 13, 2023 19:22
patelchandni
patelchandni approved these changes Mar 13, 2023
View reviewed changes
Copy link

@patelchandni patelchandni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message looks good.

@khkh-ms khkh-ms merged commit fabf989 into v4.x Mar 13, 2023
@khkh-ms khkh-ms deleted the khkh/ma-fix branch March 13, 2023 20:06
@obesser obesser mentioned this pull request May 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patelchandni patelchandni patelchandni approved these changes

@michaelpeng36 michaelpeng36 Awaiting requested review from michaelpeng36

@AnatoliB AnatoliB Awaiting requested review from AnatoliB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khkh-ms @patelchandni