Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad error messages on checks for AzureWebJobsStorage during publish #2672

Open
mattchenderson opened this issue Jul 28, 2021 · 1 comment
Open

Comments

@mattchenderson
Copy link
Contributor

During publish, the Core Tools checks for the presence of AzureWebJobsStorage. This is only strictly required in Linux, but we perform the check on Windows as well. The error message unfortunately assumes Linux though, so the message makes no sense when failing to deploy to a Windows app.

if (!functionApp.AzureAppSettings.ContainsKey("AzureWebJobsStorage") && functionApp.IsDynamic)
{
throw new CliException($"'{FunctionAppName}' app is missing AzureWebJobsStorage app setting. That setting is required for publishing consumption linux apps.");
}

I think it is reasonable to preserve the check over Windows but modify the error message. Related, the conditional here should be revised to capture identity-based connections for AzureWebJobsStorage, which is filed as a separate issue: #2671

@apawast
Copy link

apawast commented Aug 17, 2021

The ask here is to update the error message to: $"'{FunctionAppName}' app is missing AzureWebJobsStorage app setting. That setting is required for publishing consumption apps."

@apawast apawast added this to the Triaged milestone Aug 17, 2021
@fabiocav fabiocav removed this from the Triaged milestone Sep 8, 2021
@khkh-ms khkh-ms mentioned this issue Mar 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants