[Network] Update application gateway #22489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZengTaoxu
requested review from
jsntcy,
kairu-ms,
wangzelin007,
necusjz,
jiasli,
evelyn-ys,
zhoxing-ms and
calvinhzy
as code owners
ghost
requested a review
from 
ghost
added
the
|
Network |
necusjz
reviewed
May 18, 2022
Comment on lines
549
to
556
| - name: Update settings. (autogenerated) | ||
| text: | | ||
| az network application-gateway settings update --gateway-name MyAppGateway --name MySettings --probe MyNewProbe --resource-group MyResourceGroup | ||
| crafted: true | ||
| - name: Update settings. (autogenerated) | ||
| text: | | ||
| az network application-gateway settings update --gateway-name MyAppGateway --host-name-from-backend-pool true --name MySettings --port 80 --probe MyNewProbe --resource-group MyResourceGroup | ||
| crafted: true |
There was a problem hiding this comment.
Why these two examples have the same name?
There was a problem hiding this comment.
I will revise it.
necusjz
reviewed
May 18, 2022
| @@ -139,6 +139,7 @@ def load_arguments(self, _): | |||
| c.argument('zones', zones_type) | |||
| c.argument('custom_error_pages', min_api='2018-08-01', nargs='+', help='Space-separated list of custom error pages in `STATUS_CODE=URL` format.', validator=validate_custom_error_pages) | |||
| c.argument('firewall_policy', options_list='--waf-policy', min_api='2018-12-01', help='Name or ID of a web application firewall (WAF) policy.', validator=validate_waf_policy) | |||
| c.argument('priority', min_api='2021-08-01', type=int, help='Priority of the request routing rule. Supported SKU tiers are Standard_v2,WAF_v2') | |||
There was a problem hiding this comment.
Better to add a space:
Suggested change
| c.argument('priority', min_api='2021-08-01', type=int, help='Priority of the request routing rule. Supported SKU tiers are Standard_v2,WAF_v2') | |
| c.argument('priority', min_api='2021-08-01', type=int, help='Priority of the request routing rule. Supported SKU tiers are Standard_v2, WAF_v2.') |
necusjz
reviewed
May 18, 2022
| path, interval=30, timeout=120, threshold=8, no_wait=False, host_name_from_http_settings=None, | ||
| min_servers=None, match_body=None, match_status_codes=None, port=None): | ||
| def create_ag_probe(cmd, resource_group_name, application_gateway_name, item_name, protocol, host, path, interval=30, | ||
| timeout=120, threshold=8, no_wait=False, host_name_from_http_settings=None, min_servers=None, |
There was a problem hiding this comment.
Suggested change
| timeout=120, threshold=8, no_wait=False, host_name_from_http_settings=None, min_servers=None, | |
| timeout=120, threshold=8, no_wait=False, host_name_from_http_settings=None, min_servers=None, |
necusjz
approved these changes
May 19, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #21165
Related command
Description
'az application gateway create' : add parameter --priority,
'az network application-gateway probe' : add parameter --host-name-from-settings
add command 'az network application-gateway settings','az network application-gateway listener','az network application-gateway routing-rule'
Testing Guide
History Notes
[Network]
az network application-gateway: Addsettings,listenerandrouting-rulecommand groups[Network]
az network application-gateway create: Add parameter--priority[Network]
az network application-gateway probe: Add parameter--host-name-from-settingsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.