Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Filter app gateway case #4885

Merged
merged 1 commit into from
May 24, 2022

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Filter out the app gateway case test_aks_byo_appgw_with_ingress_appgw_addon from both azure-cli/acs and azure-cli-extensions/aks-preview.

A few days ago, the network module in azure-cli updated the SDK and the default API version to 2021-08-01. Some changes (by PR [Network] Update application gateway by ZengTaoxu · Pull Request #22489 · Azure/azure-cli (github.com)) caused the failure of the following test case test_aks_byo_appgw_with_ingress_appgw_addon(azure-cli/test_aks_commands.py at dev · Azure/azure-cli (github.com)).

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 May 24, 2022 08:09
@ghost ghost assigned zhoxing-ms May 24, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone May 24, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label May 24, 2022
@ghost ghost requested a review from yonzhan May 24, 2022 08:09
@ghost ghost added the AKS label May 24, 2022
@FumingZhang FumingZhang marked this pull request as ready for review May 24, 2022 08:27
@zhoxing-ms zhoxing-ms merged commit 901a309 into Azure:main May 24, 2022
@FumingZhang FumingZhang deleted the fuming/filter-test-0524 branch June 13, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants