Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Core} Use knack 0.8.0rc2 #16301

Merged
merged 9 commits into from
Dec 30, 2020
Merged

{Core} Use knack 0.8.0rc2 #16301

merged 9 commits into from
Dec 30, 2020

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Dec 17, 2020

Description

This PR contains these sub-PRs:

History Notes

[Core] Print INFO log from SDK (#15676)

@jiasli jiasli changed the title Use knack 0.8.0rc1 {Core} Use knack 0.8.0rc1 Dec 17, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Dec 17, 2020

Core

@yonzhan yonzhan added this to the S180 milestone Dec 17, 2020
@@ -49,7 +49,7 @@
'colorama~=0.4.1',
'humanfriendly>=4.7,<9.0',
'jmespath',
'knack==0.7.2',
'knack==0.8.0rc1',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use ~=0.8.0rc1 but 0.8.1 won't fit (it should).

>>> from packaging.specifiers import SpecifierSet
>>> "0.8.1" in SpecifierSet("~=0.8.0rc1")
False

This behavior contradicts PEP 440, and this bug is mentioned at pypa/packaging#100.

@yonzhan yonzhan modified the milestones: S180, S181 Dec 26, 2020
@jiasli jiasli changed the title {Core} Use knack 0.8.0rc1 {Core} Use knack 0.8.0rc2 Dec 28, 2020
@jiasli
Copy link
Member Author

jiasli commented Dec 29, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jiasli jiasli removed the request for review from haroldrandom December 29, 2020 04:24
@jiasli jiasli merged commit 2557860 into Azure:dev Dec 30, 2020
@jiasli jiasli deleted the knack branch December 30, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants