{Core} Use custom tag message #15730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
arrownj,
fengzhou-msft,
haroldrandom,
jsntcy,
Juliehzl and
mmyyrroonn
as code owners
|
Core |
This was referenced Dec 7, 2020
evelyn-ys
reviewed
Dec 14, 2020
| from knack.util import status_tag_messages | ||
| ref_message = "Reference and support levels: https://aka.ms/CLI_refstatus" | ||
| # Override the preview message | ||
| status_tag_messages['preview'] = "{} is in preview and under development. " + ref_message |
There was a problem hiding this comment.
Suggested change
| status_tag_messages['preview'] = "{} is in preview and under development. " + ref_message | |
| status_tag_messages['preview'] = "{} is in preview. " + ref_message |
I noticed that in knack there's no 'under development' for preview message.
There was a problem hiding this comment.
It is not necessary for Azure CLI and Knack to have the same message. The message I used in this PR has been approved by PMs and UX team.
evelyn-ys
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR requires microsoft/knack#223
Refine and override tag messages from Knack to be more user-friendly.
See email: Refining our experimental message to be more positive