Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{Core} Remove useless codes in core for ai-did-you-mean-this #15793

Merged
merged 4 commits into from
Nov 10, 2020
Merged

{Core} Remove useless codes in core for ai-did-you-mean-this #15793

merged 4 commits into from
Nov 10, 2020

Conversation

houk-ms
Copy link
Contributor

@houk-ms houk-ms commented Nov 4, 2020

Description

This PR removes the useless codes in core for ai-did-you-mean-this, as the extension was already retired.

@houk-ms
Copy link
Contributor Author

houk-ms commented Nov 4, 2020

@christopher-o-toole @mirdaki for awareness

jiasli
jiasli approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@jiasli jiasli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there may be something more to remove. See #12889 for the original change.

@mirdaki
Copy link
Contributor

mirdaki commented Nov 4, 2020

I have no problem with this.

@houk-ms
Copy link
Contributor Author

houk-ms commented Nov 5, 2020

Some codes introduce by #12889 are not removed because they are still used in command recomendations

@houk-ms houk-ms requested a review from fengzhou-msft November 6, 2020 09:48
@houk-ms
Copy link
Contributor Author

houk-ms commented Nov 9, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@houk-ms houk-ms merged commit aaa2ee7 into Azure:dev Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiasli jiasli jiasli approved these changes

@yungezz yungezz yungezz approved these changes

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

@arrownj arrownj Awaiting requested review from arrownj

@haroldrandom haroldrandom Awaiting requested review from haroldrandom

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@Juliehzl Juliehzl Awaiting requested review from Juliehzl

Assignees

@fengzhou-msft fengzhou-msft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@houk-ms @mirdaki @jiasli @yungezz @fengzhou-msft