{Aladdin} Add v0 hook to AzCliCommandParser class. #12889
Conversation
christopher-o-toole
requested review from
arrownj,
fengzhou-msft,
haroldrandom,
jiasli,
Juliehzl and
qianwens
as code owners
|
|
|
add to S168 |
| @@ -52,6 +52,10 @@ def _get_completions(self, comp_words, cword_prefix, cword_prequote, last_wordbr | |||
| class AzCliCommandParser(CLICommandParser): | |||
| """ArgumentParser implementation specialized for the Azure CLI utility.""" | |||
|
|
|||
| @staticmethod | |||
| def recommendation_provider(version, command, parameters, extension): | |||
| pass | |||
There was a problem hiding this comment.
I noticed there are many cases where recommendation can be triggered, please list all of these cases in the PR description. Including how to trigger them.
Use logger.debug to log the args and make sure they are provided as expected.
We can schedule a meeting to further discuss this design.
There was a problem hiding this comment.
I will put a more detailed description of some of the most common cases where recommendations are triggered soon.
I'd like to schedule a meeting with you if you have time. I'll contact you on Teams for details.
There was a problem hiding this comment.
Added better logging through logger.debug.
There was a problem hiding this comment.
Added table of different command failures. Will add additional details sometime tonight.
…ck info, rename variables, more robust command parsing, don't change add_parser kwargs, remove telemetry check.
Co-Authored-By: Jiashuo Li <[email protected]>
Co-Authored-By: Jiashuo Li <[email protected]>
Co-Authored-By: Jiashuo Li <[email protected]>
…-o-toole/azure-cli into thoth-extension-hook
Description of PR (Mandatory)
Add hook to allow extensions to make suggestions on parser failures.
Failure Types