Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containerapp 0.3.12 Release #5392

Merged
merged 35 commits into from
Oct 7, 2022
Merged

Containerapp 0.3.12 Release #5392

merged 35 commits into from
Oct 7, 2022

Conversation

StrawnSC
Copy link
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

StrawnSC and others added 15 commits September 14, 2022 10:33
@StrawnSC
bump version
2e3db8a
@runefa @StrawnSC
Custom Domains on Managed Environments (Azure#152)
3665e8b 
* initial no dockerfile support for up

* bump version

* add to help text, history text

* Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502)

* pass target port to ACR task; add better error information

* bump version

* fix bug with containerapp create

* add test case

* bump version

* Updated to preview api version and reran all tests. (Azure#147)

* Ran tests.

* Update src/containerapp/azext_containerapp/_clients.py

Co-authored-by: Silas Strawn <[email protected]>

Co-authored-by: Haroon Feisal <[email protected]>
Co-authored-by: Silas Strawn <[email protected]>

* resolve anthony's comments

* Revert "`az containerapp up`: Support No Dockerfile Scenario"

* Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario""

* Added custom domain support to env create.

* Updated param help group text.

* Added test.

* Wrote env update, wrote test for env update with custom domains.

* Minor update.

* Added help to env update.

Co-authored-by: Silas Strawn <[email protected]>
Co-authored-by: Haroon Feisal <[email protected]>
Fixed style issues.
f38613a
Reran failing tests.
e6a2bce
@pauldotyu
Migrating containerapp-compose into containerapp
bba5c1f
@StrawnSC
Merge pull request Azure#155 from smurawski/compose-migration
56c2777 
Migrating containerapp-compose into containerapp
@StrawnSC
fix style
226c11e
@StrawnSC
fix tests
bb564dc
@StrawnSC
Revert "Migrating containerapp-compose into containerapp"
77be903
@StrawnSC
Merge pull request Azure#157 from calvinsID/revert-155-compose-migration
a77a1a9 
Revert "Migrating containerapp-compose into containerapp"
Added exposedPort to models.
474cb50
Merge branch 'containerapp-0.3.12' of https://github.com/calvinsID/az…
f47f244 
…ure-cli-extensions into containerapp-0.3.12
@runefa
TCP support. (Azure#156)
8efcac5 
* Finished feature.

* Fixed comments.

Co-authored-by: Haroon Feisal <[email protected]>
@RakeshMohanMSFT
{containerapp} Fix #23934: Add validation for revision suffix parameter
22568cf
@RakeshMohanMSFT
{containerapp} Fix #23934: Add validation for revision suffix parameter
322e2c9
@ghost ghost requested a review from yonzhan September 27, 2022 16:20
@ghost ghost added the Auto-Assign Auto assign by bot label Sep 27, 2022
@ghost ghost requested a review from wangzelin007 September 27, 2022 16:20
@ghost ghost assigned zhoxing-ms Sep 27, 2022
@ghost ghost added this to the Sep 2022 (2022-10-12) - For Ignite milestone Sep 27, 2022
@ghost ghost added the ContainerApp label Sep 27, 2022
@ghost ghost requested review from zhoxing-ms and jsntcy September 27, 2022 16:20
@StrawnSC StrawnSC mentioned this pull request Sep 27, 2022
Closed
3 tasks
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 27, 2022

Containerapp

panchagnula
panchagnula reviewed Oct 4, 2022
View reviewed changes
.github/CODEOWNERS
@@ -230,7 +230,7 @@

/src/quota/ @kairu-ms @ZengTaoxu

/src/containerapp/ @calvinsID @haroonf @panchagnula @StrawnSC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this can you add Linlu to the list.

panchagnula
panchagnula suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments - otherwise looks good.

@StrawnSC StrawnSC requested a review from panchagnula October 5, 2022 01:16
@StrawnSC
Copy link
Contributor Author

StrawnSC commented Oct 5, 2022 •
edited
Loading

@zhoxing-ms, I'm not sure why the verify ref docs CI check is failing. Do you know what's causing that?

It looks like this change for reservations might have caused the verify ref docs regression: 06c9144

panchagnula
panchagnula approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@panchagnula
Copy link
Contributor

@zhoxing-ms when you are back - could you please help us with unblocking the PR & releasing this ASAP. We would also have another release following this in time for Ignite. Thanks

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Oct 6, 2022 •
edited
Loading

It looks like this change for reservations might have caused the verify ref docs regression: 06c9144

The CI problems will be solved by this PR #5421

@StrawnSC StrawnSC requested a review from zhoxing-ms October 6, 2022 20:16
@wangzelin007
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@panchagnula
Copy link
Contributor

@zhoxing-ms thanks seem like the build passed now. If you are good with the change could we get this merged & released today please?

@zhoxing-ms zhoxing-ms merged commit 7a98bcb into Azure:main Oct 7, 2022
@azclibot
Copy link
Collaborator

azclibot commented Oct 7, 2022 •
edited by wangzelin007
Loading

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=7546&view=results

@zioproto zioproto mentioned this pull request Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@panchagnula panchagnula panchagnula approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@jsntcy jsntcy Awaiting requested review from jsntcy

@runefa runefa Awaiting requested review from runefa

Assignees

@zhoxing-ms zhoxing-ms

Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Milestone
Sep 2022 (2022-10-12) - For Ignite
Development

Successfully merging this pull request may close these issues.
9 participants
@StrawnSC @yonzhan @panchagnula @zhoxing-ms @wangzelin007 @azclibot @runefa @pauldotyu @RakeshMohanMSFT