-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document for supported runtime versions #1502
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrawnSC
added a commit
to StrawnSC/azure-cli-extensions
that referenced
this pull request
Aug 3, 2022
pauld-msft
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
runefa
added a commit
to calvinsID/azure-cli-extensions
that referenced
this pull request
Sep 15, 2022
* initial no dockerfile support for up * bump version * add to help text, history text * Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502) * pass target port to ACR task; add better error information * bump version * fix bug with containerapp create * add test case * bump version * Updated to preview api version and reran all tests. (#147) * Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Silas Strawn <[email protected]> * resolve anthony's comments * Revert "`az containerapp up`: Support No Dockerfile Scenario" * Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario"" * Added custom domain support to env create. * Updated param help group text. * Added test. * Wrote env update, wrote test for env update with custom domains. * Minor update. * Added help to env update. Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]>
p-bouchon
pushed a commit
to p-bouchon/azure-cli-extensions
that referenced
this pull request
Feb 24, 2023
* initial no dockerfile support for up * bump version * add to help text, history text * Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502) * pass target port to ACR task; add better error information * bump version * fix bug with containerapp create * add test case * bump version * Updated to preview api version and reran all tests. (Azure#147) * Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Silas Strawn <[email protected]> * resolve anthony's comments * Revert "`az containerapp up`: Support No Dockerfile Scenario" * Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario"" * Added custom domain support to env create. * Updated param help group text. * Added test. * Wrote env update, wrote test for env update with custom domains. * Minor update. * Added help to env update. Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]>
p-bouchon
pushed a commit
to p-bouchon/azure-cli-extensions
that referenced
this pull request
Mar 20, 2023
* initial no dockerfile support for up * bump version * add to help text, history text * Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502) * pass target port to ACR task; add better error information * bump version * fix bug with containerapp create * add test case * bump version * Updated to preview api version and reran all tests. (Azure#147) * Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Silas Strawn <[email protected]> * resolve anthony's comments * Revert "`az containerapp up`: Support No Dockerfile Scenario" * Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario"" * Added custom domain support to env create. * Updated param help group text. * Added test. * Wrote env update, wrote test for env update with custom domains. * Minor update. * Added help to env update. Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]>
yanzhudd
pushed a commit
to Azure/azure-cli-extensions
that referenced
this pull request
Mar 31, 2023
…-preview (#6081) * bump version * Updated to preview api version and reran all tests. (#147) * Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Silas Strawn <[email protected]> * initial premium sku implementation * bump version * Custom Domains on Managed Environments (#152) * initial no dockerfile support for up * bump version * add to help text, history text * Fill in Cormac's link for oryx runtimes (see here microsoft/Oryx#1502) * pass target port to ACR task; add better error information * bump version * fix bug with containerapp create * add test case * bump version * Updated to preview api version and reran all tests. (#147) * Ran tests. * Update src/containerapp/azext_containerapp/_clients.py Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Silas Strawn <[email protected]> * resolve anthony's comments * Revert "`az containerapp up`: Support No Dockerfile Scenario" * Revert "Revert "`az containerapp up`: Support No Dockerfile Scenario"" * Added custom domain support to env create. * Updated param help group text. * Added test. * Wrote env update, wrote test for env update with custom domains. * Minor update. * Added help to env update. Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> * add/update premium sku features -- updates for api changes, up/containerapp create support, env update support, add help text * workaround for updating workload profiles * start testing; handle logging differently in update * private preview * automatically add WP to environment if needed * unhardcode premium sku * wlp changes * fix auto lowercase * change version * change version * merge conflicts * fix wlp commands * fix enable wlp * change log analytics * wlp updates * wlp commands * fix lowercase issues * v1.0.4 add name and change type * reset to v1.0.3 * v1.0.3 fix optional workload profile name * update to 1.0.5, create containerapp with friendly name * fix param names for 1.0.5 * change put to patch for update managed env * 1.0.6, fix update container app and make wlp type optional * fix other conflicts * switch to 11-01-preview * fix failing test scenario * update workload profile tests * add help for wlp commands * cleanup some comments * fix styling * fix polling * fix unintended rebasing change * fix lint * revert appLogsConfiguration in create_managedenvironment and fix pylint * remove useless file and fix liner * fix * fix tags patch bug * re run test * change enable-workload-profiles * remove usless test yml file * revert poll change * add preview flag * fix preview --------- Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: p-bouchon <[email protected]> Co-authored-by: xinyu pang <[email protected]> Co-authored-by: xinyu pang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a document that lists all runtime versions supported by Oryx to be present alongside the existing
supportedPlatformVersions.md
document that lists all platform versions in our storage account.In the future, we should work to make this document dynamic like the platform versions document by pulling the versions from
https://mcr.microsoft.com/v2/oryx/{platform}/tags/list
- [ ] Tests are included and/or updated for code changes.- [ ] Proper license headers are included in each file.