-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue #5361
Update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue #5361
Conversation
src/spring/HISTORY.md
Outdated
@@ -1,13 +1,11 @@ | |||
Release History | |||
=============== | |||
|
|||
1.1.7 | |||
1.1.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We skip 1.1.6
and 1.1.7
on purpose, since they have compatibility issue with CLI core with version < 2.38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we only hide version 1.1.6
at present, so the version 1.1.7
has not been released, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
1.1.7
hasn't been updated intosetup.py
.- Also
1.1.7
hasn't been merged intoindex.json
.
spring |
0b288fe
to
85634ba
Compare
Do not merge. This PR was created to fix an urgent issue. But now, the issue was mitigated with PR: #5360, we'll get back to this PR on next week. Thank you! |
Add some test result from Azure Spring Apps team:
The failed case is an unknown issue, and will be fixed later.
The failed case is a known issue, and will be fixed later. |
To add some more context of Azure CLI change that breaks the compatibility. |
@zhoxing-ms Our extension spring 1.1.7 has passed internal tests, now it's ready to be reviewed, merged, and released. |
[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1858066&view=results |
Link the feature request: #4640 |
update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az spring
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.