Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue #5361

Merged

Conversation

jiec-msft
Copy link
Contributor

update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az spring

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@@ -1,13 +1,11 @@
Release History
===============

1.1.7
1.1.8
Copy link
Contributor Author

@jiec-msft jiec-msft Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We skip 1.1.6 and 1.1.7 on purpose, since they have compatibility issue with CLI core with version < 2.38

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we only hide version 1.1.6 at present, so the version 1.1.7 has not been released, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,

  1. 1.1.7 hasn't been updated into setup.py.
  2. Also 1.1.7 hasn't been merged into index.json.

src/spring/HISTORY.md Outdated Show resolved Hide resolved
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 16, 2022

spring

@jiec-msft jiec-msft force-pushed the mason/update-min-cli-core-version-for-spring branch from 0b288fe to 85634ba Compare September 16, 2022 09:41
@jiec-msft
Copy link
Contributor Author

@zhoxing-ms

Do not merge.

This PR was created to fix an urgent issue. But now, the issue was mitigated with PR: #5360, we'll get back to this PR on next week.

Thank you!

@jiec-msft jiec-msft changed the title update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue [Do no merge] update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue Sep 16, 2022
@jiec-msft
Copy link
Contributor Author

jiec-msft commented Sep 19, 2022

Add some test result from Azure Spring Apps team:

  1. CLI core 2.38.0 with spring extension 1.1.7
    Azure DevOps(ADO) Link: https://msazure.visualstudio.com/AzureDMSS/_build/results?buildId=60609530&view=results
    Screenshot:

image

The failed case is an unknown issue, and will be fixed later.

  1. CLI core 2.39.0 with spring extension 1.1.7
    ADO Link: https://msazure.visualstudio.com/AzureDMSS/_build/results?buildId=60609522&view=results
    Screenshot:

image

The failed case is an unknown issue, and will be fixed later.
  1. CLI core 2.40.0 with spring extension 1.1.7
    ADO Link: https://msazure.visualstudio.com/AzureDMSS/_build/results?buildId=60609513&view=results
    Screenshot:

image

The failed case is a known issue, and will be fixed later.

Take 2.38.0 test release to verify test environment:
image

@jiec-msft jiec-msft changed the title [Do no merge] update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue Update min cli core version from 2.30.0 to 2.38.0 to fix the compatibility issue Sep 19, 2022
@jiec-msft
Copy link
Contributor Author

Add evidence that Azure CLI Core 2.37.0 is not compatible with our extension spring V1.1.6

image

@jiec-msft
Copy link
Contributor Author

To add some more context of Azure CLI change that breaks the compatibility.
Azure/azure-cli#22676

@jiec-msft
Copy link
Contributor Author

@zhoxing-ms Our extension spring 1.1.7 has passed internal tests, now it's ready to be reviewed, merged, and released.

@zhoxing-ms zhoxing-ms merged commit 261d29b into Azure:main Sep 19, 2022
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1858066&view=results

@jiec-msft
Copy link
Contributor Author

Link the feature request: #4640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants