-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Add compatibility validation between CLI extension and CLI Core "azext.minCliCoreVersion" #4640
Comments
route to CXP team |
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ShichaoQiu, @yuwzho, @yucwan. Issue DetailsFeature requestBackgroundFor Spring-cloud extension, we released Related PR
RequestIn the pull request of an extension, run the CI with at least 2 Azure CLI version:
Known issueIn class ByosTest(ScenarioTest):
@ResourceGroupPreparer()
@StorageAccountPreparer()
def test_persistent_storage(self, resource_group, storage_account):
template = 'storage account keys list -n {} -g {} --query "[0].value" -otsv'
accountkey = self.cmd(template.format(storage_account, resource_group)).output
|
Looks like the route by this bot is not correct, please ignore this @ShichaoQiu @yuwzho |
@jsntcy With the growing possibility, would you consider priority increase of this feature request? |
It's in our Zn planning, and we'll discuss inside our team and prioritize accordingly. |
Great to know this, thank you! |
Hey @jsntcy, may I ask for the update? |
Feature request
Background
For Spring-cloud extension, we released
3.1.0
including introduce new SDK for 2022-03-01-preview apiVersion. However, this sdk imports a library available in Azure CLI Core from version2.30.0
, however, theazext.minCliCoreVersion
for3.1.0
is2.25.0
. Customer who uses Azure CLI among [2.25.0
,2.30.0
) will failed all commands forspring-cloud
extension3.1.0
.Related PR
Request
In the pull request of an extension, run the CI with at least 2 Azure CLI version:
Known issue
In
src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_scenario.py::ByosTest::test_persistent_storage
, there is an annotation@StorageAccountPreparer()
, when running the test, with azure-cli2.34.1
, it's calling to storage account with apiVersion2020-08-01
, where older azure-cli is using2020-06-01
, which mean cannot find the request in recording file. However, it's the unit test self failure, not the extension failure.The text was updated successfully, but these errors were encountered: