Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add compatibility validation between CLI extension and CLI Core "azext.minCliCoreVersion" #4640

Open
jiec-msft opened this issue Apr 6, 2022 · 7 comments
Assignees
Labels
Auto-Assign Auto assign by bot CI feature-request This issue requires a new behavior in the product in order be resolved. Test Test
Milestone

Comments

@jiec-msft
Copy link
Contributor

Feature request

Background

For Spring-cloud extension, we released 3.1.0 including introduce new SDK for 2022-03-01-preview apiVersion. However, this sdk imports a library available in Azure CLI Core from version 2.30.0, however, the azext.minCliCoreVersion for 3.1.0 is 2.25.0. Customer who uses Azure CLI among [2.25.0, 2.30.0) will failed all commands for spring-cloud extension 3.1.0.

Related PR

Request

In the pull request of an extension, run the CI with at least 2 Azure CLI version:

  1. Version specified in "azext.minCliCoreVersion" for an extension.
  2. latest

Known issue

In src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_scenario.py::ByosTest::test_persistent_storage, there is an annotation @StorageAccountPreparer(), when running the test, with azure-cli 2.34.1, it's calling to storage account with apiVersion 2020-08-01, where older azure-cli is using 2020-06-01, which mean cannot find the request in recording file. However, it's the unit test self failure, not the extension failure.

class ByosTest(ScenarioTest):

    @ResourceGroupPreparer()
    @StorageAccountPreparer()
    def test_persistent_storage(self, resource_group, storage_account):
        template = 'storage account keys list -n {} -g {} --query "[0].value" -otsv'
        accountkey = self.cmd(template.format(storage_account, resource_group)).output
@ghost ghost added Auto-Assign Auto assign by bot CXP Attention This issue is handled by CXP team. Spring Cloud Spring Cloud related issues Storage labels Apr 6, 2022
@ghost ghost added this to the Backlog milestone Apr 6, 2022
@ghost ghost assigned evelyn-ys Apr 6, 2022
@ghost ghost added the Account label Apr 6, 2022
@ghost ghost assigned jiasli Apr 6, 2022
@jiec-msft jiec-msft changed the title [Feature request] Validate extension compatibility with CLI Core "azext.minCliCoreVersion" [Feature request] Add compatibility validation between CLI extension and CLI Core "azext.minCliCoreVersion" Apr 6, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 6, 2022

route to CXP team

@SaurabhSharma-MSFT SaurabhSharma-MSFT added Service Attention This issue is responsible by Azure service team. and removed CXP Attention This issue is handled by CXP team. labels Apr 6, 2022
@ghost
Copy link

ghost commented Apr 6, 2022

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ShichaoQiu, @yuwzho, @yucwan.

Issue Details

Feature request

Background

For Spring-cloud extension, we released 3.1.0 including introduce new SDK for 2022-03-01-preview apiVersion. However, this sdk imports a library available in Azure CLI Core from version 2.30.0, however, the azext.minCliCoreVersion for 3.1.0 is 2.25.0. Customer who uses Azure CLI among [2.25.0, 2.30.0) will failed all commands for spring-cloud extension 3.1.0.

Related PR

Request

In the pull request of an extension, run the CI with at least 2 Azure CLI version:

  1. Version specified in "azext.minCliCoreVersion" for an extension.
  2. latest

Known issue

In src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_scenario.py::ByosTest::test_persistent_storage, there is an annotation @StorageAccountPreparer(), when running the test, with azure-cli 2.34.1, it's calling to storage account with apiVersion 2020-08-01, where older azure-cli is using 2020-06-01, which mean cannot find the request in recording file. However, it's the unit test self failure, not the extension failure.

class ByosTest(ScenarioTest):

    @ResourceGroupPreparer()
    @StorageAccountPreparer()
    def test_persistent_storage(self, resource_group, storage_account):
        template = 'storage account keys list -n {} -g {} --query "[0].value" -otsv'
        accountkey = self.cmd(template.format(storage_account, resource_group)).output
Author: jiec-msft
Assignees: -
Labels:

Service Attention, Spring Cloud, Auto-Assign

Milestone: Backlog

@jiec-msft
Copy link
Contributor Author

Looks like the route by this bot is not correct, please ignore this @ShichaoQiu @yuwzho

@jsntcy jsntcy added feature-request This issue requires a new behavior in the product in order be resolved. and removed Service Attention This issue is responsible by Azure service team. labels May 5, 2022
@jiec-msft
Copy link
Contributor Author

@jsntcy
With the CLI PR: Azure/azure-cli#22676
Our extension spring 1.1.6 met the same issue again and fixed in PR: #5361

With the growing possibility, would you consider priority increase of this feature request?

@jsntcy jsntcy self-assigned this Sep 19, 2022
@jsntcy jsntcy added CI Test Test and removed Spring Cloud Spring Cloud related issues labels Sep 19, 2022
@jsntcy
Copy link
Member

jsntcy commented Sep 19, 2022

It's in our Zn planning, and we'll discuss inside our team and prioritize accordingly.

@jiec-msft
Copy link
Contributor Author

Great to know this, thank you!

@jiec-msft
Copy link
Contributor Author

Hey @jsntcy, may I ask for the update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI feature-request This issue requires a new behavior in the product in order be resolved. Test Test
Projects
None yet
Development

No branches or pull requests

6 participants