[Spring-cloud] Find min version requirement of Azure CLI #4626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
3.1.0
with below PRs:3.1.0
is not compatible with Azure CLI2.26.0
. It's caused by SDK introduced in earlier PR.3.1.1
to add min Azure CLI version from2.25.0
to latest2.34.1
with below PR3.1.0
fromindex.json
manually with below PR, so that customer will not be able to install it.2.30.0
, and the extension is compatible from all versions of azure cli since2.30.0
. So this pr:3.1.2
2.30.0
3.1.0
What tests I've carries out
3.1.2
version of spring-cloud extension with different Azure CLI versions with below pipelines((Azure Spring Cloud team's pipeline) ):2.29.2
and spring-cloud extensionA minor problem with recording test is:
In
src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_scenario.py::ByosTest::test_persistent_storage
, there is an annotation@StorageAccountPreparer()
, when running the test, with azure-cli2.34.1
, it's calling to storage account with apiVersion2020-08-01
, where older azure-cli is using2020-06-01
, which mean cannot find the request in recording file. However, it's the unit test self failure, not the extension failure.Follow-ups
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.