Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring-cloud] Find min version requirement of Azure CLI #4626

Merged

Conversation

jiec-msft
Copy link
Contributor

@jiec-msft jiec-msft commented Apr 3, 2022


What does this PR do

  1. We released spring-cloud CLI extension 3.1.0 with below PRs:
  2. We find spring-cloud extension 3.1.0 is not compatible with Azure CLI 2.26.0. It's caused by SDK introduced in earlier PR.
  3. We release spring-cloud 3.1.1 to add min Azure CLI version from 2.25.0 to latest 2.34.1 with below PR
  1. We also deleted spring-cloud 3.1.0 from index.json manually with below PR, so that customer will not be able to install it.
  1. In this PR, we verified that min supported Azure CLI version is 2.30.0, and the extension is compatible from all versions of azure cli since 2.30.0. So this pr:
  • Release CLI 3.1.2
  • Update min cli core version requirement to 2.30.0
  • Update the spring-cloud release history to remove 3.1.0

What tests I've carries out

A minor problem with recording test is:

In src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_scenario.py::ByosTest::test_persistent_storage, there is an annotation @StorageAccountPreparer(), when running the test, with azure-cli 2.34.1, it's calling to storage account with apiVersion 2020-08-01, where older azure-cli is using 2020-06-01, which mean cannot find the request in recording file. However, it's the unit test self failure, not the extension failure.

class ByosTest(ScenarioTest):

    @ResourceGroupPreparer()
    @StorageAccountPreparer()
    def test_persistent_storage(self, resource_group, storage_account):
        template = 'storage account keys list -n {} -g {} --query "[0].value" -otsv'
        accountkey = self.cmd(template.format(storage_account, resource_group)).output

Follow-ups

  • How to test such the compatibility among Azure CLI extension and Azure CLI properly?

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost added Spring Cloud Spring Cloud related issues Auto-Assign Auto assign by bot labels Apr 3, 2022
@ghost ghost requested review from zhoxing-ms, wangzelin007 and yonzhan April 3, 2022 15:01
@ghost ghost assigned zhoxing-ms Apr 3, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 3, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 4, 2022

Spring-cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Spring Cloud Spring Cloud related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants