Update aks kollect command to use Periscope version 0.0.10
#5248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
assigned 
|
❤️❤️☕️🪄 thank you so much for this @peterbom , and hiya @FumingZhang can you please help us to identify why this test is failing. ❤️🙏 thank you. |
|
aks |
FumingZhang
approved these changes
Aug 18, 2022
zhoxing-ms
approved these changes
Aug 18, 2022
|
@peterbom Could you please resolve those conflicts? |
pfrcks
pushed a commit
to pfrcks/azure-cli-extensions
that referenced
this pull request
Dec 1, 2022
* [k8s-extension] Update extension CLI to v1.3.2 (Azure#5245) * [Release] Update index.json for extension [ k8s-extension ] Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1788975&view=results Last commit: Azure@203ec06 * [IoT] IoT Extension Release v0.17.0 (Azure#5249) * [TA] change rolebinding create command parameter roles to comma-seperated (Azure#5166) * Update `aks kollect` command to use Periscope version 0.0.10 (Azure#5248) * bump k8s-extension version to 1.3.3 Co-authored-by: Azure CLI Team <[email protected]> Co-authored-by: Victoria Litvinova <[email protected]> Co-authored-by: Yitong Feng <[email protected]> Co-authored-by: peterbom <[email protected]> Co-authored-by: Bavneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
aks kollectcommand so that it uses the latest Periscope version, which includes enhanced support for Windows log collection (amongst other quality updates).This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
aks
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.