Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA] change rolebinding create command parameter roles to comma-seperated #5166

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

YitongFeng-git
Copy link
Contributor

@YitongFeng-git YitongFeng-git commented Jul 28, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

Test:

image

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please also update history.rst (and setup.py if you want to release a new version) and add some description about the change.

Also, since the feature is basically available, time to add a live test case for it?

@YitongFeng-git YitongFeng-git changed the title [TA] change rolebinding create command roles to comma seperate [TA] change rolebinding create command parameter roles to comma-seperated Jul 28, 2022
@YitongFeng-git
Copy link
Contributor Author

YitongFeng-git commented Jul 28, 2022

LGTM

Please also update history.rst (and setup.py if you want to release a new version) and add some description about the change.

Also, since the feature is basically available, time to add a live test case for it?

Updated history, and the tests will be added in August.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 28, 2022

AKS

@yonzhan yonzhan requested a review from zhoxing-ms July 28, 2022 09:17
@yonzhan yonzhan requested a review from jsntcy July 28, 2022 09:17
@yonzhan yonzhan added this to the Aug 2022 (2022-09-06) milestone Jul 28, 2022
@FumingZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@zhoxing-ms zhoxing-ms merged commit 1653739 into Azure:main Aug 18, 2022
@YitongFeng-git YitongFeng-git deleted the yife/binding branch August 18, 2022 09:41
pfrcks pushed a commit to pfrcks/azure-cli-extensions that referenced this pull request Dec 1, 2022
* [k8s-extension] Update extension CLI to v1.3.2 (Azure#5245)

* [Release] Update index.json for extension [ k8s-extension ]

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1788975&view=results

Last commit: Azure@203ec06

* [IoT] IoT Extension Release v0.17.0 (Azure#5249)

* [TA] change rolebinding create command parameter roles to comma-seperated (Azure#5166)

* Update `aks kollect` command to use Periscope version 0.0.10 (Azure#5248)

* bump k8s-extension version to 1.3.3

Co-authored-by: Azure CLI Team <[email protected]>
Co-authored-by: Victoria Litvinova <[email protected]>
Co-authored-by: Yitong Feng <[email protected]>
Co-authored-by: peterbom <[email protected]>
Co-authored-by: Bavneet Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants