-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TA] change rolebinding create command parameter roles to comma-seperated #5166
Conversation
db57646
to
8d14c8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please also update history.rst (and setup.py if you want to release a new version) and add some description about the change.
Also, since the feature is basically available, time to add a live test case for it?
Updated history, and the tests will be added in August. |
AKS |
f285e54
to
043f2f7
Compare
/azp run |
No pipelines are associated with this pull request. |
* [k8s-extension] Update extension CLI to v1.3.2 (Azure#5245) * [Release] Update index.json for extension [ k8s-extension ] Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1788975&view=results Last commit: Azure@203ec06 * [IoT] IoT Extension Release v0.17.0 (Azure#5249) * [TA] change rolebinding create command parameter roles to comma-seperated (Azure#5166) * Update `aks kollect` command to use Periscope version 0.0.10 (Azure#5248) * bump k8s-extension version to 1.3.3 Co-authored-by: Azure CLI Team <[email protected]> Co-authored-by: Victoria Litvinova <[email protected]> Co-authored-by: Yitong Feng <[email protected]> Co-authored-by: peterbom <[email protected]> Co-authored-by: Bavneet Singh <[email protected]>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json
.Test: