Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} pip Install testsdk remove the --no-deps parameter #4824

Merged
merged 1 commit into from
May 16, 2022

Conversation

wangzelin007
Copy link
Member

@wangzelin007 wangzelin007 commented May 16, 2022


CI raise error:
image
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1569165&view=logs&j=9c80867e-ccda-50f1-65bc-e11447f3cda9&t=8e28b004-aba6-5a56-67c2-9d40a66e3ed9

  • Fix: Install testsdk with requirements.

CI raise error:
image

  • Fix: pip Install azure-cli with --editable to include tests directory.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost added Auto-Assign Auto assign by bot CI labels May 16, 2022
@ghost ghost requested review from yonzhan, jiasli and kairu-ms May 16, 2022 03:09
@ghost ghost assigned wangzelin007 May 16, 2022
@ghost ghost added this to the May 2022 (2022-05-24) milestone May 16, 2022
@wangzelin007
Copy link
Member Author

wangzelin007 commented May 16, 2022

Use #4822 to test Azure.azure-cli-extensions (Integration Tests):
image

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a trivial modification (PR #4822) to test if the fix works?

@wangzelin007
Copy link
Member Author

wangzelin007 commented May 16, 2022

Based on a trivial modification (PR #4822) to test if the fix works?

Because integration test is a diff test,will use multiple pull requests to make sure it works.
Any suggestion ?

@FumingZhang
Copy link
Member

No problem for me, just a little curious

@wangzelin007
Copy link
Member Author

wangzelin007 commented May 16, 2022

Use #4711 to test Azure.azure-cli-extensions (Integration Tests):
image

@wangzelin007
Copy link
Member Author

wangzelin007 commented May 16, 2022

From error log, the tests folder from cli was not included? It was included before.

image

Fix: pip Install azure-cli with --editable to include tests directory.

@wangzelin007 wangzelin007 force-pushed the fix-pipeline-error-20220516 branch 3 times, most recently from cefbd53 to 6081d4a Compare May 16, 2022 04:08
@wangzelin007 wangzelin007 force-pushed the fix-pipeline-error-20220516 branch 2 times, most recently from 570c5f0 to b80e357 Compare May 16, 2022 07:10
@wangzelin007 wangzelin007 changed the title {CI} pip Install testsdk remove the --nodeps parameter {CI} pip Install testsdk remove the --no-deps parameter May 16, 2022
@wangzelin007 wangzelin007 requested a review from zhoxing-ms May 16, 2022 07:18
@wangzelin007 wangzelin007 merged commit de460da into Azure:main May 16, 2022
@wangzelin007 wangzelin007 deleted the fix-pipeline-error-20220516 branch May 16, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants