Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerapp-compose extension with support for compose files #4711

Merged
merged 17 commits into from
Jun 4, 2022

Conversation

smurawski
Copy link
Contributor

@smurawski smurawski commented Apr 20, 2022

This is a preview extension to explore supporting consumption of Azure ContainerApps from a Docker Compose specification.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested a review from yonzhan April 20, 2022 19:41
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 20, 2022
@ghost ghost requested a review from wangzelin007 April 20, 2022 19:41
@ghost ghost assigned zhoxing-ms Apr 20, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 20, 2022
@ghost ghost added the ContainerApp label Apr 20, 2022
@ghost ghost requested review from zhoxing-ms and jsntcy April 20, 2022 19:41
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 20, 2022

containerapp-preview

@panchagnula
Copy link
Contributor

@yonzhan this is a completely different extension from the ACA extension my team owns, hence please have core-cli team review & provide help / feedback. Thanks!

@smurawski smurawski force-pushed the containerapp-preview branch from a45e1c0 to 179f724 Compare May 3, 2022 16:46
@zhoxing-ms
Copy link
Contributor

File "/home/vsts/work/1/s/src/containerapp-preview/azext_containerapp_preview/custom.py", line 12, in
from azext_containerapp.custom import (
ModuleNotFoundError: No module named 'azext_containerapp'

Could you please fix this import issue?

@zhoxing-ms
Copy link
Contributor

@smurawski Please add exclusion in CredScanSuppressions.json file to solve the Credential Scan issue

@zhoxing-ms
Copy link
Contributor

Please fix the Static Analysis issue

@smurawski smurawski force-pushed the containerapp-preview branch 2 times, most recently from 931e9df to 2678fa2 Compare May 5, 2022 19:04
@anthonychu
Copy link
Member

@panchagnula Do you have a suggestion for the extension name? containerapp-preview might be too generic if it's specifically for the compose support.

@panchagnula
Copy link
Contributor

@panchagnula Do you have a suggestion for the extension name? containerapp-preview might be too generic if it's specifically for the compose support.

containerapp-dockercompose?

@smurawski smurawski force-pushed the containerapp-preview branch from 221cdb2 to 1944163 Compare May 5, 2022 23:02
@smurawski
Copy link
Contributor Author

@panchagnula Do you have a suggestion for the extension name? containerapp-preview might be too generic if it's specifically for the compose support.

@anthonychu I left the naming of the extension generic as Daria mentioned that there may be more things that you might want to experiment with as the main extension becomes more stable. Happy to change it at any point.

@smurawski smurawski force-pushed the containerapp-preview branch 8 times, most recently from 7f217b7 to eecbef6 Compare May 12, 2022 22:38
@smurawski smurawski force-pushed the containerapp-preview branch from eecbef6 to 10e0456 Compare May 13, 2022 20:23
@smurawski smurawski force-pushed the containerapp-preview branch 2 times, most recently from 81806a5 to 44dae34 Compare May 19, 2022 12:12
@smurawski
Copy link
Contributor Author

Thank you for the review @zhoxing-ms

I've made the required changes and have rebased on top of main (though that keeps moving).

The build is green again. Anything else I need to address?

@smurawski smurawski force-pushed the containerapp-preview branch from fc76941 to 3e7fc98 Compare June 1, 2022 18:54
@smurawski smurawski force-pushed the containerapp-preview branch from 3e7fc98 to 75b87d6 Compare June 2, 2022 16:17
@smurawski
Copy link
Contributor Author

Anything left that would block us getting this shipped @zhoxing-ms ?

@zhoxing-ms zhoxing-ms merged commit c6d86ee into Azure:main Jun 4, 2022
@smurawski smurawski deleted the containerapp-preview branch June 6, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants