-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerapp-compose extension with support for compose files #4711
Conversation
containerapp-preview |
@yonzhan this is a completely different extension from the ACA extension my team owns, hence please have core-cli team review & provide help / feedback. Thanks! |
a45e1c0
to
179f724
Compare
Could you please fix this import issue? |
@smurawski Please add exclusion in |
Please fix the |
931e9df
to
2678fa2
Compare
@panchagnula Do you have a suggestion for the extension name? |
containerapp-dockercompose? |
221cdb2
to
1944163
Compare
@anthonychu I left the naming of the extension generic as Daria mentioned that there may be more things that you might want to experiment with as the main extension becomes more stable. Happy to change it at any point. |
7f217b7
to
eecbef6
Compare
eecbef6
to
10e0456
Compare
src/containerapp-compose/azext_containerapp_compose/azext_metadata.json
Outdated
Show resolved
Hide resolved
81806a5
to
44dae34
Compare
Thank you for the review @zhoxing-ms I've made the required changes and have rebased on top of main (though that keeps moving). The build is green again. Anything else I need to address? |
src/containerapp-compose/azext_containerapp_compose/azext_metadata.json
Outdated
Show resolved
Hide resolved
...containerapp-compose/azext_containerapp_compose/vendored_sdks/azext_containerapp/commands.py
Outdated
Show resolved
Hide resolved
…[email protected]> Signed-off-by: Jessica Deen <[email protected]>
…[email protected]> Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
…provided to support recordable tests
Co-authored-by: Xing Zhou <[email protected]>
…ntainerapp. Use load_yaml_file from containerapp (remove copy/pasted code).
fc76941
to
3e7fc98
Compare
3e7fc98
to
75b87d6
Compare
Anything left that would block us getting this shipped @zhoxing-ms ? |
This is a preview extension to explore supporting consumption of Azure ContainerApps from a Docker Compose specification.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.