Connectedk8s extension helm chart cleanup #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed container status check
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Co-Authored-By: Shashank Barsin <[email protected]>
Pavan/distro detect
added telemetry code for connect cli
Location data
raunakpandya
reviewed
Sep 8, 2020
| # Check for faulty pre-release helm versions | ||
| if "3.3.0-rc" in helm_version: | ||
| telemetry.set_user_fault() | ||
| raise CLIError("The current helm version is not supported for azure-arc onboarding. Please upgrade the helm version and try again.") |
There was a problem hiding this comment.
helm version [](start = 111, length = 12)
Please upgrade to a stabel helm release may be as the message? or specify the version minimum needed? #Closed
There was a problem hiding this comment.
Changed the message to upgrade to stable version as 3.0.0 also works but 3.3.0-rc dosent as it was a pre-release version
There was a problem hiding this comment.
raunakpandya
reviewed
Sep 8, 2020
raunakpandya
reviewed
Sep 8, 2020
| try: | ||
| if os.path.isdir(path): | ||
| shutil.rmtree(path) | ||
| except: |
There was a problem hiding this comment.
except [](start = 4, length = 6)
What are the chances of this happening?
There was a problem hiding this comment.
This might happen if some other program(not terminal) is accessing the charts directory. I saw this when I had opened the charts in VS code.
raunakpandya
reviewed
Sep 8, 2020
fengzhou-msft
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.