Location data #2

akashkeshari · 2020-04-01T07:03:57Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

src/connect_2020/azext_connect_2020/vendored_sdks/version.py

src/connectedk8s/azext_connectedk8s/custom.py

rapatchi · 2020-04-13T06:56:59Z

src/connectedk8s/azext_connectedk8s/custom.py

+        api_response = api_instance.list_node()
+        return len(api_response.items)
+    except ApiException as e:
+        print("Exception when calling CoreV1Api->list_node: %s\n" % e)


why are we not raising CLIError here?. Same for get_server_version and get_agent_version

src/connectedk8s/azext_connectedk8s/custom.py

shashankbarsin · 2020-04-19T12:29:00Z

src/connectedk8s/azext_connectedk8s/custom.py

+    check_helm_version(kube_config, kube_context)
+
+    # Validate location
+    resourceClient = _resource_client_factory(cmd.cli_ctx, subscription_id=subscription_id)
    if location is None:
        try:
            location = resourceClient.resource_groups.get(resource_group_name).location


The error string in except clause needs to be changed from

raise CLIError("The provided resource group does not exist. Please provide location to create the Resource Group")

to

raise CLIError("The resource group '{}' does not exist and has to be created. Connected cluster resource creation is supported only in the locations: ".format(resource_group_name) + ', '.join(map(str, rp_locations)) + ". Use the --location flag to specify one of these locations.")

src/connectedk8s/azext_connectedk8s/custom.py

shashankbarsin · 2020-04-19T14:51:15Z

src/connectedk8s/azext_connectedk8s/custom.py

-            connect_agent_state = None
-    if connect_agent_state is None:
-        raise CLIError("There was a problem with connect-agent deployment. Please run 'kubectl -n azure-arc logs -l app.kubernetes.io/component=connect-agent -c connect-agent' to debug the error.")
+            logger.warning("Exception when calling get pods: %s\n" % e)


If this log line is printed on CLI output, change to

logger.warning("Error occurred when retrieving pod information: %s\n" % e)

src/connectedk8s/azext_connectedk8s/custom.py

shashankbarsin · 2020-04-19T15:30:35Z

src/connectedk8s/azext_connectedk8s/custom.py

+    try:
+        client.delete(resource_group_name, cluster_name)
+    except CloudError as ex:
+        raise CLIError(ex)


Question: What's printed in such cases? Entire verbose content of error? Also would this be printed even without user specifying --debug?

Co-Authored-By: Shashank Barsin <[email protected]>

* feat: add aks-custom-headers for nodepool and update add version change add parameters * fix test failure add help

* WIP {KubernetesConfiguration} Add CLI * Fix Pylint errors * Added Scenario test and addressed review comments * Address review comments * Added to CodeOwners and other fixes * Fix more errors reported by static tools * Fix one more error reported by static tool * Updated the SDK with the official version * Update src/k8sconfiguration/azext_k8sconfiguration/commands.py Co-Authored-By: Feiyue Yu <[email protected]> * Address PR comments * Updated the sdk files to fix api-version parameter issue * Update src/k8sconfiguration/azext_k8sconfiguration/custom.py Co-Authored-By: Xiaojian Xu <[email protected]> * addressed more comments * remove Optional from help message * Remove azure-cli-core dependency * Pulled new version of sdk, and help text update * Updated test and other style fixes * Removed unused import * Update min Cli core version * Added revision to the updated minCliCoreVersion Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: Feiyue Yu <[email protected]> Co-authored-by: Xiaojian Xu <[email protected]> Co-authored-by: Xiaojian Xu <[email protected]>

…#1700) Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=392553 Last commit: Azure@df6806d

Pavan/distro detect

added telemetry code for connect cli

…e#1887) * Added --enable-azure-rbac flag in ManagedClusterAadProfile (#2) * Changed flag to enable-azure-rbac instead of aad-enable-azure-rbac * resolving comment for akspreview * Regenerated recordings for aks-preview ingress appgw Co-authored-by: root <root@anshenoVM.da12rmhqn3xunlrjlf1ytzev1d.bx.internal.cloudapp.net>

* Azure quantum extension v0 (#2) Initial version. * Fixing style issues * Incorporating feedback (#6) * readme * feedback * Help * Make storage account optional (Azure#7) * Storage is now optional (Azure#8) * Making storage an argument, not an env variable (Azure#9) * Adding implementation of 'az quantum workspace delete' command. * Setting new temporary version. * Fixing missing file in test change * Adding details to README.md (#5) * Updating generated files for Azure Quantum resource manager from new swagger file version * Remove manual edit of generated file. * Updating generated files for Azure Quantum data plane from new swagger file version * Updating generated files for Azure Quantum resource manager from new swagger file version. (2020-11-06) (Azure#13) * Adding implementation of 'az quantum workspace create' command. (Azure#14) Adding initial implementation of 'az quantum workspace create' command. ----------------------------------- Command az quantum workspace create : Creates a new Azure Quantum workspace. Command group 'quantum' is in preview. It may be changed/removed in a future release. Arguments --location -l : Location. Values from: az account list-locations. You can configure the default location using az configure --defaults location=<location>. --resource-group -g : Name of resource group. You can configure the default group using az configure --defaults group=<name>. --storage_account -sa : Name of the storage account to be used by a quantum workspace. --workspace-name -w : Name of the Quantum Workspace. You can configure the default workspace using az quantum workspace set. * Update Azure CLI quantum extension to multi-region (Azure#17) This change will set the URL for the data plan API accordingly with a location parameter specified as part of the command. * Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. (Azure#16) Updating swagger files per commit 44563991425d862ba4e8090a2b5b6caf8333600c in azure-rest-api-specs-pr. * Fixing tests for multi-region URL change on Az CLI quantum extension (Azure#19) Fixing tests for multi-region URL change on Az CLI quantum extension * Incorporating ARM feedback (Azure#18) * Picking up latest changes from swagger after ARM feedback * updated create_or_update * run command * Setting default location in workspace calls if not specified (Azure#20) * updating python azure quantum rest client (Azure#21) * Update generated files from swagger file (Version 2021-01-11) (Azure#22) * Hot fixes on December 2020 release of Azure CLI extension (Azure#23) * Fixing issue with over specification of location * Updating version information of extension * Update CLI with generated clients from more recent swagger files (Azure#24) - Data plane updated to official swagger file (2021-01-11 19:01:32 UTC) on azure-rest-api-specs @ 98ae52b. - Resource manager updated to candidate swagger file (2021-01-15 19:35:41 UTC) on anpaz:quantum/resource-manager @ a9a9e271c13500aa54fdbb1bcb656eb61d82d38b. * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Require location as a mandatory parameter in workspace specification (Azure#25) * Make location mandatory in commands * Update test recordings * Resetting the version history for the released version. * Fix description of workspace clear command * Updatig Readme file to RST format. * Update Readme file per pull request comments. * Fixing az quantum run and execute commands to include location parameter * Performing role assignment on storage account on workspace creation. (Azure#29) * Add warning message about providers during workspace creation (Azure#30) * Enable command az quantum workspace quotas (Azure#31) * Removing extra space in Readme.rst Co-authored-by: Feiyue Yu <[email protected]> * Fix punctuation in Readme.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/README.rst Co-authored-by: Feiyue Yu <[email protected]> * Update src/quantum/azext_quantum/_params.py Co-authored-by: Feiyue Yu <[email protected]> * First round of code review feedback on Readme.rst * Improve code readability on job commands * Avoid IndexError in case of malformed URL * Extended info on targetId parameter * Add help to each individual command * Reorganize sections in Readme.rst and merge in a single set of instructions. * Static analysis fixes * Fix CLI Linter errors * Fix CLI Linter errors. Part 2 * Fix typo in show command. * Fix show command for Linter * Use standard name for show command method * Modify workspace create test to skip role assignment * Update tests with workspace names used currently. * Update test recordings. * Set subscription for the recordings. * Update test recordings. * Update QDK version number * Remove asserts and checks for subscription * Experiment: Remove check for preview subscription * Refresh recordings with current test values. * Update recordings after typo fix. * Remove commented out API that references subscription * Enable QuantumJobsScenarioTest.test_submit_args only on live mode Co-authored-by: Ricardo Espinoza <[email protected]> Co-authored-by: Feiyue Yu <[email protected]>

Akash Keshari added 6 commits March 25, 2020 04:04

Added 2020 version models and operations

85aa7d9

Updated with key pair generation

d345685

review of public private key pair

4e90290

updated models with latest changes in swagger

836e6fc

Update CLI to support SPN less onboarding

a1bea49

Removed location data changes

6522421

rapatchi reviewed Apr 13, 2020

View reviewed changes

src/connect_2020/azext_connect_2020/vendored_sdks/version.py Outdated Show resolved Hide resolved

rapatchi reviewed Apr 13, 2020

View reviewed changes

shashankbarsin suggested changes Apr 19, 2020

View reviewed changes

akashkeshari and others added 21 commits April 21, 2020 09:13

Update src/connectedk8s/azext_connectedk8s/custom.py

dec8fab

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

9bd5580

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

854b36f

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

576704d

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

b26a0eb

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

6d445c3

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

9df8269

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

031639b

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

47ca292

Co-Authored-By: Shashank Barsin <[email protected]>

Update src/connectedk8s/azext_connectedk8s/custom.py

b237d9c

Co-Authored-By: Shashank Barsin <[email protected]>

Updated error messages

6249ea7

resolved a conflict

5223949

updated wrt style checks

c1ecbf8

Added a recorded test

f43ebfb

Updated with latest master changes

32c5089

Updated imports

a97f36e

removed python 2.x from setup.py

025522c

Updated format.py

1967b02

Updated readme file

df87f51

Updated test file

b747e92

updated setup.py

9d9c954

Akash Keshari and others added 27 commits April 30, 2020 20:45

updated print statement to warnings

44f4547

added telemetry code for connect cli

3fa9b10

Added exception telemetry for delete operation

5c56299

Updated with latest master

47fc01b

Updated setup.py

9239f83

Changed default kubernetes distro

ccdbff0

Distro detect.

e6333d7

Updated history

1ef6cdd

removed arm resourceid from telemetry

c1612c2

Kubernetes connect cli telemetry integration (Azure#1684)

db1f4bd

bump vmware to 0.6.0 (Azure#1656)

5ed8f5d

download from az-csvmware-cli (Azure#1681)

9943139

[Release] Update index.json for extension [ connectedk8s ] (Azure#1689)

feb1883

AKS: add aks-custom-headers for nodepool and update (Azure#1686)

fb40791

* feat: add aks-custom-headers for nodepool and update add version change add parameters * fix test failure add help

Merge branch 'akash/connect_telemetry' into pavan/distro_detect

3ed99da

[Release] Update index.json for extension [ aks-preview ] (Azure#1699)

8a92c0c

Add kubernetes distro and identifying it.

8b26810

Add "Did You Mean This" Extension (Azure#1692)

87cbfa1

[Release] Update index.json for extension [ k8sconfiguration ] (Azure…

6bb06a7

…#1700) Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=392553 Last commit: Azure@df6806d

Remove additional line.

fdacc2b

correct indentation.

3860c00

Merge branch 'master' into pavan/distro_detect

b9b4915

correct indentation.

f8c4e04

correct version number.

b752e92

Merge pull request #5 from akashkeshari/pavan/distro_detect

9404057

Pavan/distro detect

Merge pull request #4 from akashkeshari/akash/connect_telemetry

669071f

added telemetry code for connect cli

akashkeshari merged commit 65e69b8 into master May 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Location data #2

Location data #2

akashkeshari commented Apr 1, 2020

rapatchi Apr 13, 2020

shashankbarsin Apr 19, 2020

shashankbarsin Apr 19, 2020

shashankbarsin Apr 19, 2020

Location data #2

Location data #2

Conversation

akashkeshari commented Apr 1, 2020

General Guidelines

rapatchi Apr 13, 2020

Choose a reason for hiding this comment

shashankbarsin Apr 19, 2020

Choose a reason for hiding this comment

shashankbarsin Apr 19, 2020

Choose a reason for hiding this comment

shashankbarsin Apr 19, 2020

Choose a reason for hiding this comment