[Breadth Coverage] Log Analytics Solution #1545

zhoxing-ms · 2020-04-15T05:27:59Z

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

azuresdkci · 2020-04-15T05:28:01Z

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/zhoxing-ms/azure-cli-extensions.git@dev#subdirectory=src/$EXT&egg=$EXT"

yonzhan · 2020-04-15T08:46:35Z

add to S168

jsntcy · 2020-04-16T02:13:04Z

src/log-analytics-solution/azext_log_analytics_solution/azext_metadata.json

+{
+    "azext.isExperimental": true,
+    "azext.minCliCoreVersion": "2.0.67",
+    "azext.maxCliCoreVersion": "3.0.0"


Please don't set maxCliCoreVersion here

"azext.minCliCoreVersion" should be at least "2.3.0"; otherwise 'experimental' tag is not available. Please test if 'experimental' tag works first.

Please don't set maxCliCoreVersion here
"azext.minCliCoreVersion" should be at least "2.3.0"

Done

otherwise 'experimental' tag is not available. Please test if 'experimental' tag works first.

Yeah, tag had been tested and can be used normally #Closed

qianwens

jsntcy · 2020-04-26T08:34:42Z

src/log-analytics-solution/setup.py

+    'Intended Audience :: Developers',
+    'Intended Audience :: System Administrators',
+    'Programming Language :: Python',
+    'Programming Language :: Python :: 2',


remove python 2, 2.7 as we will not support them any longer. #Closed

jsntcy · 2020-04-26T08:36:16Z

src/log-analytics-solution/azext_log_analytics_solution/commands.py

+                            client_factory=cf_solutions, is_experimental=True) as g:
+        g.custom_command('create', 'create_monitor_log_analytics_solution')
+        g.custom_command('update', 'update_monitor_log_analytics_solution')
+        g.custom_command('delete', 'delete_monitor_log_analytics_solution')


add 'confirmation=True' for delete command #Closed

jsntcy · 2020-04-26T08:36:57Z

src/log-analytics-solution/azext_log_analytics_solution/custom.py

+# pylint: disable=unused-argument
+
+
+def create_monitor_log_analytics_solution(cmd, client,


parameter cmd is not used, remove it. please also check not used cmd in other methods.

jsntcy · 2020-04-26T08:50:55Z

src/log-analytics-solution/azext_log_analytics_solution/_params.py

+        c.argument('plan_publisher', help='Publisher name of the plan for solution. For gallery solution, it is Microsoft.')
+        c.argument('plan_product', help='Product name of the plan for solution. '
+                                        'For Microsoft published gallery solution it should be in the format of OMSGallery/<solutionType>. This is case sensitive.')
+        c.argument('workspace_resource_id', options_list=['--workspace-resource-id', '-w'],


please support workspace name as well #Closed

I mean use one argument "workspace" that supports both name and resource id as storage_account does.

In reply to: 415257345 [](ancestors = 415257345)

jsntcy · 2020-04-26T08:55:47Z

src/log-analytics-solution/azext_log_analytics_solution/_params.py

+def load_arguments(self, _):
+
+    with self.argument_context('monitor log-analytics solution create') as c:
+        c.argument('resource_group', resource_group_name_type)


unnecessary to add resource_group here as it's a global argument added by cli core automatically.
please also remove it in other methods. #Closed

jsntcy · 2020-04-26T08:57:08Z

src/log-analytics-solution/azext_log_analytics_solution/_params.py

+
+    with self.argument_context('monitor log-analytics solution create') as c:
+        c.argument('resource_group', resource_group_name_type)
+        c.argument('name', options_list=['--name', '-n'], help='Name of the log-analytics solution.')


name [](start = 20, length = 4)

name [](start = 20, length = 4)

use solution_name here and define a CLIArgumentType for reuse #Closed

jsntcy · 2020-04-26T08:58:54Z

src/log-analytics-solution/azext_log_analytics_solution/custom.py

+
+
+def create_monitor_log_analytics_solution(cmd, client,
+                                          resource_group,


resource_group [](start = 42, length = 14)

resource_group [](start = 42, length = 14)

resource_group_name #Closed

jsntcy · 2020-04-26T09:06:32Z

src/log-analytics-solution/azext_log_analytics_solution/custom.py

+
+def update_monitor_log_analytics_solution(cmd, client,
+                                          resource_group,
+                                          name,


name [](start = 42, length = 4)

name [](start = 42, length = 4)

solution_name #Closed

jsntcy · 2020-04-26T09:08:37Z

src/log-analytics-solution/azext_log_analytics_solution/custom.py

+    if tags is not None:
+        body['tags'] = tags  # dictionary
+
+    return client.create_or_update(resource_group_name=resource_group, solution_name=name, parameters=body)


use update (which is a patch) instead. #Closed

jsntcy · 2020-04-26T09:09:05Z

src/log-analytics-solution/azext_log_analytics_solution/commands.py

+
+    with self.command_group('monitor log-analytics solution', log_analytics_solution_solutions,
+                            client_factory=cf_solutions, is_experimental=True) as g:
+        g.custom_command('create', 'create_monitor_log_analytics_solution')


add supports_no_wait=True for create/update/delete #Closed

jsntcy · 2020-04-26T09:16:42Z

src/log-analytics-solution/azext_log_analytics_solution/_help.py

+        text: |-
+               az monitor log-analytics solution create --resource-group MyResourceGroup \\
+               --name MySolutionGroup --location "East US" --tags key=value \\
+               --plan-name PlanName --plan-publisher PlanPublisher --plan-product PlanProduct \\


Could the example be more specific for some arguments such a publisher, product? #Closed

jsntcy · 2020-04-26T09:52:24Z

src/log-analytics-solution/azext_log_analytics_solution/custom.py

+def create_monitor_log_analytics_solution(cmd, client,
+                                          resource_group,
+                                          name,
+                                          location,


location=None to make it optional as it can be extracted from resource group. #Closed

jsntcy · 2020-04-26T09:54:20Z

src/log-analytics-solution/azext_log_analytics_solution/custom.py

+                                          name,
+                                          location,
+                                          workspace_resource_id,
+                                          plan_name,


plan_name is same as solution name? #Closed

jsntcy · 2020-04-29T02:08:36Z

src/log-analytics-solution/azext_log_analytics_solution/custom.py

+        }
+    }
+
+    return client.create_or_update(resource_group_name=resource_group_name, solution_name=solution_name, parameters=body)


wrap with "sdk_no_wait", like "return sdk_no_wait(no_wait, client.create_or_update, resource_group_name, cluster_name, cluster_instance)". Please also update other commands that support no wait. #Closed

jiasli · 2020-04-29T06:21:11Z

src/log-analytics-solution/azext_log_analytics_solution/_help.py

+helps['monitor log-analytics solution'] = """
+    type: group
+    short-summary: Commands to manage monitor log-analytics solution.
+"""


No need to indent the help. Ctrl+A to select all, then press Shift+Tab to remove the indentations.

jsntcy

jsntcy · 2020-04-29T08:08:43Z

src/log-analytics-solution/azext_log_analytics_solution/_validators.py

        if not is_valid_resource_id(namespace.workspace_resource_id):
-            raise CLIError('usage error: --workspace-resource-id is invalid')
+            raise CLIError('usage error: --workspace is invalid, it must be name of resource id of workspace')


zhoxing-ms requested review from Juliehzl, jsntcy and qianwens April 15, 2020 05:42

zhoxing-ms force-pushed the dev branch 4 times, most recently from 99c8fda to a255492 Compare April 15, 2020 07:14

yonzhan assigned zhoxing-ms Apr 15, 2020

yonzhan added this to the S168 milestone Apr 15, 2020

zhoxing-ms force-pushed the dev branch from a255492 to b36a76a Compare April 16, 2020 01:52

jsntcy reviewed Apr 16, 2020

View reviewed changes

zhoxing-ms force-pushed the dev branch from b36a76a to 65c9e55 Compare April 16, 2020 03:20

zhoxing-ms requested a review from jsntcy April 16, 2020 03:23

yonzhan modified the milestones: S168, S169 Apr 18, 2020

zhoxing-ms requested review from haroldrandom, jiasli and mmyyrroonn April 26, 2020 02:07

qianwens approved these changes Apr 26, 2020

View reviewed changes

jsntcy reviewed Apr 26, 2020

View reviewed changes

zhoxing-ms force-pushed the dev branch 2 times, most recently from 09f5681 to ee45bfb Compare April 27, 2020 07:27

zhoxing-ms requested a review from YalinLi0312 as a code owner April 27, 2020 07:27

zhoxing-ms force-pushed the dev branch 2 times, most recently from 3d4990f to c1101e9 Compare April 27, 2020 07:46

Support log analytics solution

a311afa

zhoxing-ms force-pushed the dev branch from c1101e9 to a311afa Compare April 27, 2020 07:48

Remove --plan-name

a97c149

jsntcy reviewed Apr 29, 2020

View reviewed changes

zhoxing-ms force-pushed the dev branch from f77009b to 843da5a Compare April 29, 2020 04:36

Support sdk_no_wait, remove location and modify workspace

864fcf3

zhoxing-ms force-pushed the dev branch from 843da5a to 864fcf3 Compare April 29, 2020 05:00

jiasli reviewed Apr 29, 2020

View reviewed changes

Format code

1aee95a

zhoxing-ms force-pushed the dev branch from 93c4ec5 to 1aee95a Compare April 29, 2020 07:37

jsntcy approved these changes Apr 29, 2020

View reviewed changes

jsntcy reviewed Apr 29, 2020

View reviewed changes

update yaml

8dc3cf7

zhoxing-ms force-pushed the dev branch from 8346355 to 8dc3cf7 Compare April 29, 2020 09:27

zhoxing-ms merged commit 14799ae into Azure:master Apr 29, 2020

jiasli mentioned this pull request May 7, 2020

[Breadth Coverage] Onboard Custom Providers Commands #1627

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Breadth Coverage] Log Analytics Solution #1545

[Breadth Coverage] Log Analytics Solution #1545

zhoxing-ms commented Apr 15, 2020 •

edited

Loading

azuresdkci commented Apr 15, 2020

yonzhan commented Apr 15, 2020

jsntcy Apr 16, 2020

zhoxing-ms Apr 16, 2020

zhoxing-ms Apr 16, 2020 •

edited by jsntcy

Loading

qianwens left a comment

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 29, 2020

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 29, 2020 •

edited

Loading

jiasli Apr 29, 2020

zhoxing-ms Apr 29, 2020

jsntcy left a comment

jsntcy Apr 29, 2020

		# pylint: disable=unused-argument


		def create_monitor_log_analytics_solution(cmd, client,



		def create_monitor_log_analytics_solution(cmd, client,
		resource_group,

[Breadth Coverage] Log Analytics Solution #1545

[Breadth Coverage] Log Analytics Solution #1545

Conversation

zhoxing-ms commented Apr 15, 2020 • edited Loading

General Guidelines

About Extension Publish

azuresdkci commented Apr 15, 2020

yonzhan commented Apr 15, 2020

jsntcy Apr 16, 2020

Choose a reason for hiding this comment

zhoxing-ms Apr 16, 2020

Choose a reason for hiding this comment

zhoxing-ms Apr 16, 2020 • edited by jsntcy Loading

Choose a reason for hiding this comment

qianwens left a comment

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 29, 2020

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 26, 2020 • edited Loading

Choose a reason for hiding this comment

jsntcy Apr 29, 2020 • edited Loading

Choose a reason for hiding this comment

jiasli Apr 29, 2020

Choose a reason for hiding this comment

zhoxing-ms Apr 29, 2020

Choose a reason for hiding this comment

jsntcy left a comment

Choose a reason for hiding this comment

jsntcy Apr 29, 2020

Choose a reason for hiding this comment

zhoxing-ms commented Apr 15, 2020 •

edited

Loading

zhoxing-ms Apr 16, 2020 •

edited by jsntcy

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 26, 2020 •

edited

Loading

jsntcy Apr 29, 2020 •

edited

Loading