-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breadth Coverage] Onboard Custom Providers Commands #1627
Conversation
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
|
3ba3ab5
to
de3dafe
Compare
add to S169 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Cheers
src/custom-providers/azext_custom_providers/tests/latest/test_custom-providers_scenario.py
Show resolved
Hide resolved
src/custom-providers/azext_custom_providers/tests/latest/test_custom-providers_scenario.py
Show resolved
Hide resolved
body = {'location': location, 'tags': tags, | ||
'actions': actions, 'resource_types': resource_types, | ||
'validations': validations} | ||
return sdk_no_wait(no_wait, client.create_or_update, resource_group_name=resource_group_name, resource_provider_name=resource_provider_name, resource_provider=body) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example
What does this PR do?
Which commands will be supported?
az custom-providers resource-provider create
az custom-providers resource-provider update
az custom-providers resource-provider show
az custom-providers resource-provider delete
az custom-providers resource-provider list
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions: