Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breadth Coverage] Onboard Custom Providers Commands #1627

Merged
merged 6 commits into from
May 9, 2020

Conversation

jsntcy
Copy link
Member

@jsntcy jsntcy commented Apr 30, 2020

What does this PR do?

Which commands will be supported?
az custom-providers resource-provider create
az custom-providers resource-provider update
az custom-providers resource-provider show
az custom-providers resource-provider delete
az custom-providers resource-provider list


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/jsntcy/azure-cli-extensions.git@bc-customproviders#subdirectory=src/$EXT&egg=$EXT"

@jsntcy jsntcy changed the title Support Custom Providers in Azure CLI cmdlets [Breadth Coverage] Onboard Custom Providers Commands Apr 30, 2020
@jsntcy jsntcy self-assigned this Apr 30, 2020
@jsntcy jsntcy force-pushed the bc-customproviders branch from 3ba3ab5 to de3dafe Compare April 30, 2020 07:37
@yonzhan yonzhan added this to the S169 milestone Apr 30, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 30, 2020

add to S169

src/custom-providers/azext_custom_providers/_help.py Outdated Show resolved Hide resolved
src/custom-providers/README.md Outdated Show resolved Hide resolved
src/custom-providers/README.md Outdated Show resolved Hide resolved
src/custom-providers/README.md Outdated Show resolved Hide resolved
src/custom-providers/README.md Outdated Show resolved Hide resolved
src/custom-providers/README.md Outdated Show resolved Hide resolved
src/custom-providers/README.md Outdated Show resolved Hide resolved
src/custom-providers/README.md Outdated Show resolved Hide resolved
src/custom-providers/README.md Outdated Show resolved Hide resolved
@jsntcy jsntcy force-pushed the bc-customproviders branch from de3dafe to ed025bf Compare May 8, 2020 10:09
Copy link
Contributor

@mmyyrroonn mmyyrroonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Cheers

@jsntcy jsntcy merged commit bffd137 into Azure:master May 9, 2020
body = {'location': location, 'tags': tags,
'actions': actions, 'resource_types': resource_types,
'validations': validations}
return sdk_no_wait(no_wait, client.create_or_update, resource_group_name=resource_group_name, resource_provider_name=resource_provider_name, resource_provider=body)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants