RG mode: Two step list, rg itself (incl. ext), then resources (incl. ext) in it #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
/azp list |
|
No pipelines found for this repository. |
|
/azp list |
|
Commenter does not have sufficient privileges for PR 576 in repo Azure/aztfexport |
|
/azp where |
ms-henglu
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for the #574, which doesn't handle exporting the extension resources assigned to an empty resource group. The reason is that
azlistby default query resources from the ARGResourcestable, if a resource group is empty, then the query by resource group name won't return any resource, and we end up explicitly add this empty resource group to the resource list, but didn't check if any ext resource exists on it.This PR fixes this by firstly listing the RG itself, with any ext resource if any, from the
ResourceContainerstable. Then, if the RG exists, we'll further list the resources in it, including the ext resources, from theResourcestable.Fix #573. Supersedes #575.
Test
A non-empty RG:
An empty RG: