Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #573 #575

Closed
wants to merge 1 commit into from
Closed

Fix #573 #575

wants to merge 1 commit into from

Conversation

giuliohome
Copy link

@giuliohome giuliohome commented Nov 11, 2024

@magodo
Copy link
Collaborator

magodo commented Nov 12, 2024

Hi @giuliohome, thank you for submitting this PR. I've slightly modified your version, mostly for the order and some option tunning. I've submitted a new PR #576 instead. Thank you again for this!

@magodo magodo closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants