adding TokenCredential as part of the credential type accepted #846
Conversation
test/azure/generated/AzureReport/autoRestReportServiceForAzure.ts
Outdated
Show resolved
Hide resolved
| @@ -588,7 +591,8 @@ public virtual void ConstructRuntimeImportForModelIndex(TSBuilder builder) | |||
|
|
|||
| public virtual void PackageDependencies(JSONObject dependencies) | |||
| { | |||
| dependencies.StringProperty("@azure/ms-rest-js", "^2.0.4"); | |||
| dependencies.StringProperty("@azure/ms-rest-js", "^2.2.0"); | |||
| dependencies.StringProperty("@azure/core-auth", "^1.1.4"); | |||
There was a problem hiding this comment.
I think this dependency should not be added unless there is a credential, right? Is there a simple way to check for this condition here? cc @joheredi
There was a problem hiding this comment.
I think you could check either Settings.AddCredentials or Settings.AzureArm
test/azure/generated/AzureCompositeModelClient/azureCompositeModel.ts
Outdated
Show resolved
Hide resolved
|
Are the changes from Azure/azure-sdk-for-js#13403 going to be part of this PR or a separate one? |
|
@ramya-rao-a I will address feedback and generate the updated README.md in this PR. I will mention you in the diffs after I finish. |
| @@ -1,88 +1,83 @@ | |||
| ## An isomorphic javascript sdk for - AutoRestComplexTestService | |||
|
|
|||
| This package contains an isomorphic SDK for AutoRestComplexTestService. | |||
| This package contains an isomorphic SDK (runs both in node.js and in browsers) for AutoRestComplexTestService. | |||
There was a problem hiding this comment.
@ramya-rao-a , here is an updated readme file. @joheredi how can I get a display name for a package? I currently just use a normalized package name.
This PR adds support to v4 to accept
@azure/identity'sTokenCredential. Most of the work for that support is already inms-rest-jsv2.2.0.Things to note:
TokenCredential.TokenCredentialin them.Todo:
generate an updated README.md that promotes using@azure/identitybased on Sample improvements to generated readme azure-sdk-for-js#13403.