Skip to content

Commit

Permalink
Merge pull request #846 from deyaaeldeen/identity-adapter
Browse files Browse the repository at this point in the history
adding TokenCredential as part of the credential type accepted
  • Loading branch information
deyaaeldeen authored Feb 2, 2021
2 parents 23422f2 + f2a05ba commit 277f301
Show file tree
Hide file tree
Showing 58 changed files with 1,123 additions and 800 deletions.
1 change: 1 addition & 0 deletions .gulp/gulpfile.iced
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ task 'test/azure-metadata', '', [], (done) ->
task 'test/multiapi', '', [], (done) ->
cwd = "#{basefolder}/test/multiapi"
await execute "npm install", {cwd: cwd, silent: false }, defer _
await execute "npm run bootstrap", {cwd: cwd, silent: false}, defer _
await execute "npm run build", { cwd: cwd, silent: false }, defer _
done()

Expand Down
93 changes: 72 additions & 21 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@microsoft.azure/autorest.typescript",
"version": "4.4.4",
"version": "4.5.0",
"description": "The typescript extension for classic generators in AutoRest.",
"scripts": {
"autorest": "autorest",
Expand Down Expand Up @@ -42,8 +42,8 @@
},
"homepage": "https://github.com/Azure/autorest.typescript/blob/master/README.md",
"devDependencies": {
"@azure/ms-rest-azure-js": "^2.0.1",
"@azure/ms-rest-js": "^2.0.4",
"@azure/ms-rest-azure-js": "^2.1.0",
"@azure/ms-rest-js": "^2.2.0",
"@microsoft.azure/autorest.modeler": "^2.3.47",
"@microsoft.azure/autorest.testserver": "^2.7.1",
"@ts-common/azure-js-dev-tools": "^0.7.1",
Expand Down
7 changes: 4 additions & 3 deletions src/azure/Model/CodeModelTSa.cs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public override void ConstructRuntimeImportForModelIndex(TSBuilder builder)

public override void PackageDependencies(JSONObject dependencies)
{
dependencies.StringProperty("@azure/ms-rest-azure-js", "^2.0.1");
dependencies.StringProperty("@azure/ms-rest-azure-js", "^2.1.0");
base.PackageDependencies(dependencies);
}

Expand All @@ -79,6 +79,7 @@ public string GenerateAzureServiceClientImports()
TSBuilder builder = new TSBuilder();

builder.ImportAllAs("msRest", "@azure/ms-rest-js");
builder.Import(new string[] {"TokenCredential"}, "@azure/core-auth");

bool usesAzureOptionsType = OptionalParameterTypeForClientConstructor == "AzureServiceClientOptions";
if (usesAzureOptionsType || MethodTemplateModels.Any((MethodTS method) => method.IsLongRunningOperation))
Expand Down Expand Up @@ -145,9 +146,9 @@ public override string GenerateMapperIndex()
return builder.ToString();
}

protected override void GenerateNodeSampleImports(TSBuilder builder)
protected override void GenerateNodeSampleImports(JSBuilder builder)
{
GenerateNodeSampleMsRestNodeAuthImport(builder);
GenerateNodeSampleIdentityImport(builder);
GenerateNodeSampleClientImport(builder);
}

Expand Down
5 changes: 3 additions & 2 deletions src/azure/Templates/AzureServiceClientContextTemplate.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ if (usesCustomOptionsType)
}
import * as msRest from "@@azure/ms-rest-js";
import * as msRestAzure from "@@azure/ms-rest-azure-js";
import { TokenCredential } from "@@azure/core-auth";
@EmptyLine
const packageName = "@Model.Settings.PackageName";
const packageVersion = "@Model.Settings.PackageVersion";
Expand All @@ -38,7 +39,7 @@ export class @(Model.ContextName) extends msRestAzure.AzureServiceClient {
options = {};
}

if(!options.userAgent) {
if (!options.userAgent) {
const defaultUserAgent = msRestAzure.getDefaultUserAgentValue();
options.userAgent = `${packageName}/${packageVersion} ${defaultUserAgent}`;
}
Expand All @@ -65,7 +66,7 @@ export class @(Model.ContextName) extends msRestAzure.AzureServiceClient {
@EmptyLine
@foreach (var property in optionalParameters.Where(p => p.Name != "generateClientRequestId"))
{
@:if(options.@(property.Name) !== null && options.@(property.Name) !== undefined) {
@:if (options.@(property.Name) !== null && options.@(property.Name) !== undefined) {
@: this.@(property.Name) = options.@(property.Name);
@:}
}
Expand Down
Loading

0 comments on commit 277f301

Please sign in to comment.