Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paging] Expose nextLink/Continuation Token as part of the returned items #1326

Closed
deyaaeldeen opened this issue Feb 26, 2022 · 10 comments · Fixed by #1639
Closed

[Paging] Expose nextLink/Continuation Token as part of the returned items #1326

deyaaeldeen opened this issue Feb 26, 2022 · 10 comments · Fixed by #1639
Labels
v6

Comments

@deyaaeldeen
Copy link
Member

Some customers need access to it to suspend and resume iterating. See Azure/azure-sdk-for-js#20380 (comment)
@deyaaeldeen deyaaeldeen added the v6 label Feb 26, 2022
@deyaaeldeen deyaaeldeen mentioned this issue Feb 26, 2022
Closed
6 tasks
@qiaozha
Copy link
Member

qiaozha commented Mar 9, 2022 •
edited
Loading

@deyaaeldeen are you going to fix this issue soon ? as this is blocking customer migrate from track1 to track2 Azure/azure-sdk-for-js#17499 (comment) Could you take this as a higher priority ?

@deyaaeldeen
Copy link
Member Author

@qiaozha I will defer to @sarangan12 and the code gen crew to address this issue but I agree it should take high priority. Also, #1199 is related and is equally if not more important since it enables customers to get pages from specific continuation tokens.

I am happy to offer guidance and to participate in any design discussions for it.

@sarangan12
Copy link
Member

@deyaaeldeen Thanks for the response (ofcourse I need your input in design :-)) . @qiaozha As this is blocking customer, I will take this as high priority and start working on this.

@qiaozha
Copy link
Member

qiaozha commented Mar 23, 2022

@sarangan12 is there any updates for this ? Thanks

@sarangan12
Copy link
Member

sarangan12 commented Mar 23, 2022 via email

@qiaozha
Copy link
Member

qiaozha commented Apr 6, 2022

@sarangan12 do you need me to review the prototype PR ? or is the design still in discussion ?

@sarangan12
Copy link
Member

@qiaozha The coding for the generator is still in progress. The scenarios are complicated and I am new to this paging operation. So, it is taking more time (This is the third day I am working on it) So, any help you could provide in that area if you have time would be appreciated,

Alternatively, you could test the change in any of the SDKs and confirm the code changes will work

@qiaozha
Copy link
Member

qiaozha commented May 11, 2022

@sarangan12 any updates with the coding change in the code generator ? I am currently working on adding back the sample generation because of audit fix don't have much time to take a look at this feature. Thanks

@MRayermannMSFT
Copy link

Sad to see this hasn't been getting attention. 😐

This was referenced Oct 24, 2022
Closed
Merged
@xirzec
Copy link
Member

xirzec commented Oct 31, 2022

@MRayermannMSFT just merged this, let me know if you have any feedback or issues with using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Paging enhancements for allowing consumers to participate in continuation xirzec/autorest.typescript
5 participants
@sarangan12 @xirzec @deyaaeldeen @MRayermannMSFT @qiaozha