-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After calling disks.grantAccess
successfully, accessSas
is undefined
#17499
Comments
@MRayermannMSFT Hi, sorry for the late response, I tried on my side and the accessSas is not undefined, Would you mind share some of your code with us so that we can look into the root cause of this issue? |
Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you! |
@qiaozha can you confirm what version of arm-compute you are using? I'm still on 16.5, but it seems like 17 was released recently. The breaking changes for that are significant enough that it will take a while for us to onboard to that. So let me know with what version you do not reproduce this issue. |
I tried both 16.5.0 and the latest one and it works on my side. Here's my code, hope it's helpful.
|
So you do reproduce the issue then. :) Check the typing for what grant access returns. The |
I see your point now |
Hi @MRayermannMSFT ,
|
@Sandido The SDK is generated from the swagger file. And as you can see the definition https://github.com/Azure/azure-rest-api-specs/blob/main/specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json#L3044-L3057 for AccessUri here, and the response model that refers to AccessUri https://github.com/Azure/azure-rest-api-specs/blob/main/specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json#L377 directly, there's nothing like properties.output.accessSAS defined in between. but we can see it from the response. which is inconsistent. Hope that can make it clear. |
I'll let @qiaozha continue with this and involve someone from the JS SDK team for better input. |
Didn't see last comment. Perhaps this is an Autorest issue that occurs in the SDK generation for JS. |
@Sandido I don't think there's anything wrong in the SDK generator for JS for this issue. According the issue and above comment, there's a clear inconsistency between the swagger response definition and the live traffic response and SDK response type is always the same with the swagger definition, if you think the live traffic response we get is the correct one, then you should fix the swgger, if you think the swagger definition is the correct one, then you should fix your service backend. |
@MRayermannMSFT I think this issue have been resolved. Could you try again and let us know if it's not ? Thanks |
Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you! |
@qiaozha can you be more specific on how/where it has been resolved? I tried again this morning and I am getting the same result. I am on v16.5.0 and I do not see a higher 16.x.y on NPM. |
@MRayermannMSFT The version I am trying is 17.1.0 I believe this is align with the swagger definition. Actually I would suggest you to migration to version 17.x.x and above because we will going to have an announcement to deprecate version lower than 17.0.0 of @azure/arm-compute early next month (March 2022). About the breaking change between the previous version and the next generation i.e. 17.x.x and above of @azure/arm-compute. You may refer to this migration guideline for help. |
Can the original issue with grantAccess be considered resolved? |
I haven't had a chance to migrate to 17 yet. I understand y'all wanting to close this issue though if you think the issue is resolve there. I can always open another issue post migration. |
@MRayermannMSFT , I will go ahead and close this issue for now. If this issue is not resolved when you migrate and test on 17, feel free to reopen this or make a new issue. |
Describe the bug
In the return value for
disks.grantAccess
,accessSas
is undefined.To Reproduce
disks.grantAccess
such that it succeedsaccessSas
on the return valueExpected behavior
The access SAS is there.
Screenshots
N/A
Additional context
You can get to the SAS by doing:
This is not a regression, I've just been lazy about opening this issue. ¯\(ツ)/¯
The text was updated successfully, but these errors were encountered: