Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 new parameters to the code gen target #3416

Merged
merged 5 commits into from
May 22, 2023
Merged

Conversation

m-nash
Copy link
Member

@m-nash m-nash commented May 17, 2023

To support this issue Azure/azure-sdk-tools#6187 we need to add 2 new parameters to the code gen target. Both flags are optional and default to false.

Depends on this getting merged first Azure/azure-sdk-tools#6197

  • /p:SaveInputs=true : This will replace the old cleanup: false that we used to put in the tsp-location.yaml and will not only keep the TempTypeSpecFiles directory around but also forward the flag to the emitter so that the cadl.json and configuration.json are kept also.
  • /p:SkipSync=true : This flag allows us to continue to run the dotnet build command to regen after making local changes to the TempTypeSpecFiles directory without replacing our local changes and without needing to copy and paste the tsp compile command from the command line

src/AutoRest.CSharp/build/CodeGeneration.targets Outdated Show resolved Hide resolved
src/AutoRest.CSharp/build/CodeGeneration.targets Outdated Show resolved Hide resolved
src/AutoRest.CSharp/build/CodeGeneration.targets Outdated Show resolved Hide resolved
src/AutoRest.CSharp/build/CodeGeneration.targets Outdated Show resolved Hide resolved
@m-nash
Copy link
Member Author

m-nash commented May 22, 2023

Waiting for this Azure/azure-sdk-tools#6197 to merge then I will run regen preview to verify no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants