Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the cleanup option to the command line #6187

Closed
m-nash opened this issue May 16, 2023 · 0 comments
Closed

Move the cleanup option to the command line #6187

m-nash opened this issue May 16, 2023 · 0 comments
Assignees
Labels
TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl)

Comments

@m-nash
Copy link
Member

m-nash commented May 16, 2023

Right now there is a cleanup option in the tsp-location.yaml file which is kind of an awkward place to put this and can lead to accidentally checking in with this option turned off.

Instead I think we should move this to a command line option -save-inputs.

This optional flag will be passed into the Typespec-Project-Generate.ps1 script and if it is passed in we will forward this flag to the emitter which can then do nothing or save any files that might be intermediate files similar to codemodel.yaml in autorest. It will also use this flag to decide whether or not to delete the TempTypeSpecFiles folder.

If not all languages support this option in their emitter we can modify the GetEmitterAdditionalOptionsFn to take in this flag and then the language specific implementation can either ignore or return back the emitter option. If we end up making this change I would like to update the signature to take a dictionary to support new params in the future without a breaking signature change.

@m-nash m-nash self-assigned this May 16, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 16, 2023
@kurtzeborn kurtzeborn added SDK Automation TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl) and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 22, 2023
@m-nash m-nash closed this as completed May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl)
Projects
None yet
Development

No branches or pull requests

2 participants