This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
update azure-sdk-for-go to v19 #3608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Installing vendored go-bindata binaries * Updating deis go-dev image
…grading from < 0.17.0-provisioned clusters (Azure#3208)
… calico or cilium (Azure#3271)
…grading from < 0.17.0-provisioned clusters (Azure#3208)
… calico or cilium (Azure#3271)
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3608 +/- ##
========================================
+ Coverage 55.4% 55.5% +0.1%
========================================
Files 107 107
Lines 16210 16194 -16
========================================
+ Hits 8981 8989 +8
+ Misses 6453 6432 -21
+ Partials 776 773 -3 |
|
/lgtm |
|
@jackfrancis: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
added a commit
that referenced
this pull request
Aug 3, 2018
# Conflicts: # Gopkg.lock # Gopkg.toml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This is a blatant rip-off of #3545, but with a potentially cleaner commit history from recent master.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: