Get sub from azure CLI when not provided #3519
Conversation
| @@ -118,3 +120,15 @@ func AcceleratedNetworkingSupported(sku string) bool { | |||
| } | |||
| return true | |||
| } | |||
|
|
|||
| // GetHomeDir attempts to get the home dir from env | |||
| func GetHomeDir() string { | |||
There was a problem hiding this comment.
A unit test for this new helper function would be great
There was a problem hiding this comment.
Sure, I'm just not sure how to adequately test it without basically putting the same exact logic in the test itself.
Signed-off-by: Brian Goff <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cpuguy83 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3519 +/- ##
==========================================
+ Coverage 55.47% 55.85% +0.38%
==========================================
Files 105 105
Lines 16004 16024 +20
==========================================
+ Hits 8879 8951 +72
+ Misses 6376 6324 -52
Partials 749 749 |
What this PR does / why we need it:
When a user doesn't provide a subscription explicitly, try to use the selected subscription from azure CLI.
Special notes for your reviewer:
Not sure if it's overkill to first check what the selected cloud is vs just always looking for
AzureCloud.If applicable:
Release note: