Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

fix(oms): pull oms directly from docker #3294

Merged
merged 1 commit into from
Jun 19, 2018
Merged

fix(oms): pull oms directly from docker #3294

merged 1 commit into from
Jun 19, 2018

Conversation

seanknox
Copy link
Contributor

What this PR does / why we need it:

  • We (Microsoft/AKS) maintain a CDN cache of docker.io at dockerio.azureedge.net that has become unreliable recently due a backend change by Docker. This unreliability manifests as returning HTTP 405 or HTTP 401 errors from the backend which are then passed to clients of dockerio.azureedge.net. - We are working with Docker to create a new image caching proxy. In the interim (and per their advice) this change pulls OMS directly from Docker Hub.
pull from Docker directly instead of using unreliable CDN proxy

@acs-bot
Copy link

acs-bot commented Jun 16, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seanknox
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cecilerobertmichon

Assign the PR to them by writing /assign @cecilerobertmichon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ghost ghost assigned seanknox Jun 16, 2018
@ghost ghost added the in progress label Jun 16, 2018
jackfrancis
jackfrancis approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit da7b1ee into master Jun 19, 2018
@ghost ghost removed the in progress label Jun 19, 2018
@dtzar dtzar deleted the remove-docker-cdn branch June 19, 2018 20:30
PaulCharlton added a commit to ElementAnalytics/acs-engine that referenced this pull request Jun 20, 2018
@PaulCharlton
Merge branch 'master' of https://github.com/Azure/acs-engine
5579523 
* 'master' of https://github.com/Azure/acs-engine: (44 commits)
  remove duplicate ebtables (Azure#3308)
  Kubernetes: Remove Windows-specific foo for control plane config (Azure#3240)
  add k8s 1.8.14 (Azure#3303)
  run /usr/lib/apt/apt.systemd.daily in background (Azure#3304)
  add annotation to secrets field (Azure#3292)
  fix(oms): pull oms directly from docker (Azure#3294)
  ensure params vals are bool, with test (Azure#3285)
  udpate to latest 16.04 LTS image (Azure#3286)
  Enable openshift e2e tests on centos (Azure#2910)
  remove docker dependency from hyperkube extract (Azure#3296)
  remove pathological test (Azure#3291)
  Refactor validateDNSPrefix function in one place (Azure#3276)
  remove unnecessary nil check (Azure#3290)
  Fixing panic issue in Validate when properties are nil (Azure#3242)
  Updating the omsagent yaml file to include new changes for node zero dependency (Azure#3277)
  revert Azure CNI to 1.0.4 (Azure#3289)
  Add e2e test for openshift vnet (Azure#3274)
  Support upgrading a Kubernetes cluster that contains Virtual Machine Scale Sets (Azure#3223)
  Set extension for custom DNS (Azure#3264)
  don't exit CSE on apt.systemd.daily error (Azure#3278)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@seanknox seanknox

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanknox @acs-bot @jackfrancis