Enable openshift e2e tests on centos #2910

0xmichalis · 2018-05-10T15:20:58Z

CecileRobertMichon · 2018-05-10T18:28:29Z

.circleci/config.yml

@@ -529,6 +566,10 @@ workflows:
          filters:
            branches:
              only: master
+      - openshift-3.9-centos-e2e:


Missing
requires:
- test

codecov · 2018-05-11T11:02:39Z

Codecov Report

Merging #2910 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2910   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files         104      104           
  Lines       15714    15714           
=======================================
  Hits         8308     8308           
  Misses       6671     6671           
  Partials      735      735

CecileRobertMichon

lgtm

CecileRobertMichon · 2018-05-11T18:30:10Z

@Kargakis the openshift centos e2e test failed with:

$ az group deployment create --name openshift-eastus-14694 --resource-group openshift-eastus-14694 --template-file /go/src/github.com/Azure/acs-engine/_output/openshift-eastus-14694/azuredeploy.json --parameters /go/src/github.com/Azure/acs-engine/_output/openshift-eastus-14694/azuredeploy.parameters.json
2018/05/11 18:29:04 
Error from deployment for openshift-eastus-14694 in resource group openshift-eastus-14694:exit status 1
2018/05/11 18:29:04 Command Output: ERROR: Marketplace purchase eligibilty check returned errors. See inner errors for details

CecileRobertMichon

centos test failed see my above comment

0xmichalis · 2018-05-11T19:04:48Z

.circleci/config.yml

+          echo 'export DISTRO=openshift39_centos' >> $BASH_ENV
+          echo 'export LOCATION=eastus' >> $BASH_ENV
+          echo 'export ORCHESTRATOR_RELEASE=3.9' >> $BASH_ENV
+          echo 'export CLUSTER_DEFINITION=examples/openshift.json' >> $BASH_ENV


@jim-minter this is how you configure the api model

0xmichalis · 2018-05-11T19:06:04Z

I'll look into the failure on Monday but it looks like an issue with the CI subscription not being able to access the centos image.

0xmichalis · 2018-05-15T09:44:26Z

@kwoodson can you walk me through how to check the enabled subscriptions in the centos image?

0xmichalis · 2018-05-15T12:08:55Z

Also, seeing a permission issue when running locally that needs to be fixed before we merge this

#2960

0xmichalis · 2018-05-16T09:50:29Z

@CecileRobertMichon can you please restart the test?

CecileRobertMichon · 2018-05-16T22:38:05Z

@Kargakis it failed again with $ az group deployment create --name openshift-eastus-40186 --resource-group openshift-eastus-40186 --template-file /go/src/github.com/Azure/acs-engine/_output/openshift-eastus-40186/azuredeploy.json --parameters /go/src/github.com/Azure/acs-engine/_output/openshift-eastus-40186/azuredeploy.parameters.json 2018/05/16 16:18:55 Error from deployment for openshift-eastus-40186 in resource group openshift-eastus-40186:exit status 1 2018/05/16 16:18:55 Command Output: ERROR: Marketplace purchase eligibilty check returned errors. See inner errors for details.

0xmichalis · 2018-05-17T12:29:09Z

@kwoodson any idea why we are seeing marketplace errors when using the published centos image?

kwoodson · 2018-05-17T13:43:43Z

@Kargakis, this same issue was happening previously with @jackfrancis. @haroldwongms gave the following instructions:

When you click on the staged offer in the portal, do you see an option at the bottom called "Want to deploy programmatically? Get started"
Click there and enable that for your subscription

I believe this needs to be done from the testing subscription.

0xmichalis · 2018-05-21T10:24:05Z

@CecileRobertMichon @jackfrancis ptal ^

0xmichalis · 2018-05-21T10:25:40Z

Here are the image fields used for the centos image:

acs-engine/pkg/acsengine/defaults.go

Lines 96 to 101 in bcda440

    
           DefaultOpenShift39CentOSImageConfig = AzureOSImageConfig{ 
        
           	ImageOffer:     "origin-acsengine-preview", 
        
           	ImageSku:       "centos7", 
        
           	ImagePublisher: "redhat", 
        
           	ImageVersion:   "latest", 
        
           }

0xmichalis · 2018-05-30T02:16:56Z

@CecileRobertMichon ping

CecileRobertMichon · 2018-05-30T17:23:30Z

@Kargakis the latest test failed with a vm extension provisioning error so I restarted it

CecileRobertMichon · 2018-06-14T19:02:38Z

@Kargakis please rebase

/lgtm

CecileRobertMichon

lgtm

0xmichalis · 2018-06-18T08:37:03Z

@CecileRobertMichon rebased, ptal

/unassign

CecileRobertMichon

/lgtm

acs-bot · 2018-06-18T17:43:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, kargakis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* 'master' of https://github.com/Azure/acs-engine: (44 commits) remove duplicate ebtables (Azure#3308) Kubernetes: Remove Windows-specific foo for control plane config (Azure#3240) add k8s 1.8.14 (Azure#3303) run /usr/lib/apt/apt.systemd.daily in background (Azure#3304) add annotation to secrets field (Azure#3292) fix(oms): pull oms directly from docker (Azure#3294) ensure params vals are bool, with test (Azure#3285) udpate to latest 16.04 LTS image (Azure#3286) Enable openshift e2e tests on centos (Azure#2910) remove docker dependency from hyperkube extract (Azure#3296) remove pathological test (Azure#3291) Refactor validateDNSPrefix function in one place (Azure#3276) remove unnecessary nil check (Azure#3290) Fixing panic issue in Validate when properties are nil (Azure#3242) Updating the omsagent yaml file to include new changes for node zero dependency (Azure#3277) revert Azure CNI to 1.0.4 (Azure#3289) Add e2e test for openshift vnet (Azure#3274) Support upgrading a Kubernetes cluster that contains Virtual Machine Scale Sets (Azure#3223) Set extension for custom DNS (Azure#3264) don't exit CSE on apt.systemd.daily error (Azure#3278) ...

CecileRobertMichon reviewed May 10, 2018

View reviewed changes

CecileRobertMichon approved these changes May 11, 2018

View reviewed changes

CecileRobertMichon suggested changes May 11, 2018

View reviewed changes

0xmichalis commented May 11, 2018

View reviewed changes

CecileRobertMichon added the orchestrator/openshift label May 14, 2018

ghost assigned 0xmichalis Jun 1, 2018

ghost added the in progress label Jun 1, 2018

acs-bot added the size/M label Jun 1, 2018

acs-bot assigned CecileRobertMichon Jun 14, 2018

acs-bot added lgtm approved labels Jun 14, 2018

CecileRobertMichon approved these changes Jun 14, 2018

View reviewed changes

Enable openshift e2e tests on centos

d363403

acs-bot removed the lgtm label Jun 18, 2018

acs-bot unassigned 0xmichalis Jun 18, 2018

CecileRobertMichon approved these changes Jun 18, 2018

View reviewed changes

acs-bot added the lgtm label Jun 18, 2018

acs-bot merged commit 2bc3eb7 into Azure:master Jun 19, 2018

ghost removed the in progress label Jun 19, 2018

0xmichalis deleted the centos-e2e branch June 19, 2018 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable openshift e2e tests on centos #2910

Enable openshift e2e tests on centos #2910

0xmichalis commented May 10, 2018

CecileRobertMichon May 10, 2018

0xmichalis May 11, 2018

codecov bot commented May 11, 2018 •

edited

Loading

CecileRobertMichon left a comment

CecileRobertMichon commented May 11, 2018

CecileRobertMichon left a comment

0xmichalis May 11, 2018

0xmichalis commented May 11, 2018

0xmichalis commented May 15, 2018

0xmichalis commented May 15, 2018

0xmichalis commented May 16, 2018

CecileRobertMichon commented May 16, 2018

0xmichalis commented May 17, 2018

kwoodson commented May 17, 2018

0xmichalis commented May 21, 2018

0xmichalis commented May 21, 2018

0xmichalis commented May 30, 2018

CecileRobertMichon commented May 30, 2018

CecileRobertMichon commented Jun 14, 2018

CecileRobertMichon left a comment

0xmichalis commented Jun 18, 2018

CecileRobertMichon left a comment

acs-bot commented Jun 18, 2018

Enable openshift e2e tests on centos #2910

Enable openshift e2e tests on centos #2910

Conversation

0xmichalis commented May 10, 2018

CecileRobertMichon May 10, 2018

Choose a reason for hiding this comment

0xmichalis May 11, 2018

Choose a reason for hiding this comment

codecov bot commented May 11, 2018 • edited Loading

Codecov Report

CecileRobertMichon left a comment

Choose a reason for hiding this comment

CecileRobertMichon commented May 11, 2018

CecileRobertMichon left a comment

Choose a reason for hiding this comment

0xmichalis May 11, 2018

Choose a reason for hiding this comment

0xmichalis commented May 11, 2018

0xmichalis commented May 15, 2018

0xmichalis commented May 15, 2018

0xmichalis commented May 16, 2018

CecileRobertMichon commented May 16, 2018

0xmichalis commented May 17, 2018

kwoodson commented May 17, 2018

0xmichalis commented May 21, 2018

0xmichalis commented May 21, 2018

0xmichalis commented May 30, 2018

CecileRobertMichon commented May 30, 2018

CecileRobertMichon commented Jun 14, 2018

CecileRobertMichon left a comment

Choose a reason for hiding this comment

0xmichalis commented Jun 18, 2018

CecileRobertMichon left a comment

Choose a reason for hiding this comment

acs-bot commented Jun 18, 2018

codecov bot commented May 11, 2018 •

edited

Loading