removing the vnet from scale templates #2994
Conversation
This allows a cluster to scale even if the user has added a subnet to the vnet
ghost
assigned 
|
back compat shouldn't be needed. This is called by the scale command so no change in user behavior so I wasn't planning on writing docs, but I could be persuaded. |
|
How does this PR relate to #2095? |
|
This would also fix that issue. |
Codecov Report
@@ Coverage Diff @@
## master #2994 +/- ##
==========================================
+ Coverage 50.75% 50.76% +<.01%
==========================================
Files 97 97
Lines 14682 14692 +10
==========================================
+ Hits 7452 7458 +6
- Misses 6533 6536 +3
- Partials 697 698 +1
Continue to review full report at Codecov.
|
|
Should I be concerned by the dcos and openshift failures I might of affected open shift expect the error doesn't make sense to me if that was the case. And I didn't affect dcos. I actually improved code coverage marginally. |
|
@JackQuincy probably not, both openshift and dcos e2e have been unstable this week. I restarted the tests to make sure. |
|
This is ready for review when someone has the time |
There was a problem hiding this comment.
/lgtm
pending scale test running at https://jenkins.azure-containers.io/view/acs-engine%20ad-hoc/job/k8s-scale/29
|
scale test passed I'm going to merge after lunch if no objections |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/lgtm |
|
@JackQuincy is this also going to change upgrade behavior (ie. upgrade without vnet)? |
|
@CecileRobertMichon yes for the agent parts of it, no for the master parts. Honestly we should do a small refactor here to make removing the unneeded nrp resources it's own method that gets called by the transform for scaling, that way it could be referenced by master upgrade and avoid the issues I had here previously, like load balancer services have a short outage around the template deployment. |
|
I'm running an upgrade test at https://jenkins.azure-containers.io/view/acs-engine%20ad-hoc/job/k8s-upgrade/96/console and it's been stuck on the first master deployment for a while... let's keep watching it to make sure it succeeds. Edit: the first master deployment finished, it's upgrading the agents now. |
This allows a cluster to scale even if the user has added a subnet to the vnet
* acs-engine deploy: model validation and required fields in --help * Forced apimodel validation to avoid incongruences (fixes #2025) * Added more details about required fields while deploying (fixes #2491) * WIP - Adding windows agent pool scaling * Revert "WIP - Adding windows agent pool scaling" - wrong branch This reverts commit 0eb7ece. * WIP - Windows Scaling on Availability Sets and VMSS * WIP - Naming format modified for vmss windows scaling * Merge remote-tracking branch 'Azure/patch-release-v0.16.2' into windowsscale * Fixing tests * feat(*): Bumps client-go to v7.0.0 This updates client-go to v7.0.0 and adds the needed dependencies on `k8s.io/api`. Also fixes a small issue with conflicting `uuid` library versions * testing re-vendor health make build-vendor passed! * removing the vnet from scale templates (#2994) This allows a cluster to scale even if the user has added a subnet to the vnet * Fix missing DefaultKubernetesClusterSubnet * dos2unix * Clean and go fmt * Clean and go fmt * Clean and go fmt * Fix util_test.go * Using StorageProfile.ImageReference.Publisher to understand if Windows Agent Pool in Scaling scenario * lint
This allows a cluster to scale even if the user has added a subnet to the vnet
What this PR does / why we need it:
This removes the vnet from update deployments for agents. This allows scaling operations to run on a cluster the user has added a subnet to the vnet.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Azure/AKS#349
If applicable:
Release note: