Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

More verbosity when missing required arguments #2491

Closed
bnookala opened this issue Mar 20, 2018 · 0 comments · Fixed by #2771
Closed

More verbosity when missing required arguments #2491

bnookala opened this issue Mar 20, 2018 · 0 comments · Fixed by #2771
Assignees
@danigian
Labels
cse-sync-week Triage for issues that would be good for CSE sync week, April 24-27th 2018 kind/bug size/small

Comments

@bnookala
Copy link
Contributor

Is this a request for help?:

No

Is this an ISSUE or FEATURE REQUEST? (choose one):

Issue

What version of acs-engine?:

v.0.13.1 (darwin-amd64)

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)

Kubernetes

What happened:

Tried to deploy a cluster:

$ ./acs-engine deploy --api-model cluster1_9.json --resource-group bhnook-k8s --location westus2
ERRO[0000] Unexpected response from Get Subscription: 404
FATA[0000] error validating deployCmd: failed to get client

What you expected to happen:

The 404 error above is not descriptive and masks the fact that the deployment failed due to a missing argument, subscription id.

How to reproduce it (as minimally and precisely as possible):

Run any deploy without the required --subscription-id.

Anything else we need to know:

Document minimally required arguments for a deployment in the --help text :)
@CecileRobertMichon CecileRobertMichon added size/small cse-sync-week Triage for issues that would be good for CSE sync week, April 24-27th 2018 labels Apr 24, 2018
@danigian danigian mentioned this issue Apr 25, 2018
Merged
@ghost ghost assigned danigian Apr 25, 2018
@ghost ghost added the in progress label Apr 25, 2018
@ghost ghost removed the in progress label May 2, 2018
CecileRobertMichon pushed a commit that referenced this issue May 2, 2018
@danigian
acs-engine deploy: model validation and required fields in --help (#2771
5676775 
)

* acs-engine deploy: model validation and required fields in --help

* Forced apimodel validation to avoid incongruences (fixes #2025)

* Added more details about required fields while deploying (fixes #2491)

* WIP - Adding windows agent pool scaling

* Revert "WIP - Adding windows agent pool scaling" - wrong branch

This reverts commit 0eb7ece.

* go fmt
CecileRobertMichon pushed a commit that referenced this issue Jun 1, 2018
@danigian
Scaling Windows agent pools for Availability Sets and VMSS (#2859)
c02ec75 
* acs-engine deploy: model validation and required fields in --help

* Forced apimodel validation to avoid incongruences (fixes #2025)

* Added more details about required fields while deploying (fixes #2491)

* WIP - Adding windows agent pool scaling

* Revert "WIP - Adding windows agent pool scaling" - wrong branch

This reverts commit 0eb7ece.

* WIP - Windows Scaling on Availability Sets and VMSS

* WIP - Naming format modified for vmss windows scaling

* Merge remote-tracking branch 'Azure/patch-release-v0.16.2' into windowsscale

* Fixing tests

* feat(*): Bumps client-go to v7.0.0

This updates client-go to v7.0.0 and adds the needed dependencies on
`k8s.io/api`. Also fixes a small issue with conflicting `uuid` library
versions

* testing re-vendor health

make build-vendor passed!

* removing the vnet from scale templates (#2994)

This allows a cluster to scale even if the user has added a subnet to the vnet

* Fix missing DefaultKubernetesClusterSubnet

* dos2unix

* Clean and go fmt

* Clean and go fmt

* Clean and go fmt

* Fix util_test.go

* Using StorageProfile.ImageReference.Publisher to understand if Windows Agent Pool in Scaling scenario

* lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@danigian danigian

Labels
cse-sync-week Triage for issues that would be good for CSE sync week, April 24-27th 2018 kind/bug size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

acs-engine deploy: model validation and required fields in --help
4 participants
@bnookala @jackfrancis @danigian @CecileRobertMichon