Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Configure heapster for RBAC from K8S 1.9 and above #2925

Merged
merged 1 commit into from
May 18, 2018
Merged

Configure heapster for RBAC from K8S 1.9 and above #2925

merged 1 commit into from
May 18, 2018

Conversation

kichristensen
Copy link
Contributor

@kichristensen kichristensen commented May 11, 2018

What this PR does / why we need it:
Heapster cannot list nodes and namespaces with RBAC enabled in Kubernetes 1.9 and 1.10

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@mpalumbo7
Copy link
Contributor

How does this relate to #2816 ?

@kichristensen
Copy link
Contributor Author

@ewok2030 I missed that PR, it is by design the rights have been removed on the dashboard. The dashboard stuff will be removed from this PR

@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #2925 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2925   +/-   ##
======================================
  Coverage    49.7%   49.7%           
======================================
  Files          91      91           
  Lines       13951   13951           
======================================
  Hits         6934    6934           
  Misses       6374    6374           
  Partials      643     643

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3a936...ba45a64. Read the comment docs.

@kichristensen kichristensen changed the title Setup dashboard as previous versions and configure heapster for RBAC from K8S 1.9 and 1.10 Configure heapster for RBAC from K8S 1.9 and above May 11, 2018
@mpalumbo7
Copy link
Contributor

Glad I could help!

@jackfrancis
Copy link
Member

@lachie83 Could you give this a sanity check? Thanks!

@jackfrancis
Copy link
Member

/approve
/lgtm

@acs-bot
Copy link

acs-bot commented May 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 31d15f9 into Azure:master May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants