-
Notifications
You must be signed in to change notification settings - Fork 558
RBAC-enabled dashboard for k8s 1.9 and greater #2816
RBAC-enabled dashboard for k8s 1.9 and greater #2816
Conversation
How does this fit with #2808 ? |
@CecileRobertMichon it fixes it :) (added to description) |
Weird. What is causing the e2e tests to fail? |
@ewok2030 E2E test is also broken :) will fix and commit to this PR branch |
Codecov Report
@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
- Coverage 46.92% 46.91% -0.01%
==========================================
Files 86 86
Lines 12802 12786 -16
==========================================
- Hits 6007 5999 -8
+ Misses 6240 6232 -8
Partials 555 555
Continue to review full report at Codecov.
|
@jackfrancis Anything left blocking this merge?....I'm gonna have to learn Go so I can stop asking for others to fix the things I would like fixed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR does / why we need it: RBAC-enabled dashboard config for 1.9 and greater k8s clusters
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #2808Special notes for your reviewer:
If applicable:
Release note: