Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Autofill ACI Connector credentials and enable logs #2903

Merged
merged 3 commits into from
May 23, 2018

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented May 10, 2018

What this PR does / why we need it:

  • autofills required credentials for virtual-kubelet/aci-connector addon (clientId, clientSecret, resourceGroup, tenantId, subscriptionId)
  • generates certificates required to get logs.

Fixes #2793
Closes #2574 (since this is no longer needed)

@vglafirov @aku105

@sozercan sozercan requested a review from jackfrancis May 10, 2018 02:43
@ghost ghost assigned sozercan May 10, 2018
@ghost ghost added the in progress label May 10, 2018
"kubernetesACIConnectorSubscriptionId": {
{{PopulateClassicModeDefaultValue "kubernetesACIConnectorSubscriptionId"}}
"kubernetesACIConnectorEnabled": {
{{PopulateClassicModeDefaultValue "kubernetesACIConnectorEnabled"}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sozercan see this PR:

https://github.com/Azure/acs-engine/pull/2915/files

Because this is a "bool" type we can't put a string in there (which is what PopulateClassicModeDefaultValue does)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackfrancis thanks! updated

@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@6457e15). Click here to learn what that means.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2903   +/-   ##
=========================================
  Coverage          ?   49.74%           
=========================================
  Files             ?       91           
  Lines             ?    13932           
  Branches          ?        0           
=========================================
  Hits              ?     6930           
  Misses            ?     6359           
  Partials          ?      643
Impacted Files Coverage Δ
pkg/acsengine/engine.go 63.95% <16.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6457e15...4ca3fc2. Read the comment docs.

@sozercan
Copy link
Member Author

@jackfrancis let me know if its preferred to reuse an existing cert from /etc/kubernetes/cert instead of generating new ones for VK.

@jackfrancis
Copy link
Member

@sozercan I think a dedicated cert is a fine first start, we can determine in practice if it's overkill. Is this PR a working prototype at this point?

@jackfrancis
Copy link
Member

/approve
/lgtm

pending e2e

@acs-bot
Copy link

acs-bot commented May 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit 5c5bba8 into Azure:master May 23, 2018
@ghost ghost removed the in progress label May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants