-
Notifications
You must be signed in to change notification settings - Fork 558
Autofill ACI Connector credentials and enable logs #2903
Conversation
parts/k8s/kubernetesparams.t
Outdated
"kubernetesACIConnectorSubscriptionId": { | ||
{{PopulateClassicModeDefaultValue "kubernetesACIConnectorSubscriptionId"}} | ||
"kubernetesACIConnectorEnabled": { | ||
{{PopulateClassicModeDefaultValue "kubernetesACIConnectorEnabled"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sozercan see this PR:
https://github.com/Azure/acs-engine/pull/2915/files
Because this is a "bool" type we can't put a string in there (which is what PopulateClassicModeDefaultValue does)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackfrancis thanks! updated
Codecov Report
@@ Coverage Diff @@
## master #2903 +/- ##
=========================================
Coverage ? 49.74%
=========================================
Files ? 91
Lines ? 13932
Branches ? 0
=========================================
Hits ? 6930
Misses ? 6359
Partials ? 643
Continue to review full report at Codecov.
|
@jackfrancis let me know if its preferred to reuse an existing cert from |
@sozercan I think a dedicated cert is a fine first start, we can determine in practice if it's overkill. Is this PR a working prototype at this point? |
/approve pending e2e |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Fixes #2793
Closes #2574 (since this is no longer needed)
@vglafirov @aku105