Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add docs for ACI connector clientKey val as keyvault #2574

Closed
jackfrancis opened this issue Apr 2, 2018 · 2 comments
Closed

Add docs for ACI connector clientKey val as keyvault #2574

jackfrancis opened this issue Apr 2, 2018 · 2 comments
Assignees
@sozercan
Labels
backlog

Comments

@jackfrancis
Copy link
Member

Once we mature the use-case of using clientKey as keyvault reference, let's update this doc to clarify that option:

https://github.com/Azure/acs-engine/tree/master/examples/addons/aci-connector
@jackfrancis
Copy link
Member Author

@vglafirov if you could do this extra credit work, great, otherwise this issue as a reminder

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Apr 2, 2018 •
edited
Loading

We should also append kubernetesACIConnectorClientKey to the following list:

acs-engine/pkg/acsengine/engine.go

Line 110 in 80c0c83

The following parameters could be either a plain text, or referenced to a secret in a keyvault:

@sozercan sozercan mentioned this issue May 10, 2018
Merged
@ghost ghost assigned sozercan May 10, 2018
@ghost ghost added the in progress label May 10, 2018
@ghost ghost removed the in progress label May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sozercan sozercan

Labels
backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sozercan @jackfrancis @CecileRobertMichon