Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

k8s apiserver --oidc properties are user-overridable #2603

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

jackfrancis
Copy link
Member

@jackfrancis jackfrancis commented Apr 5, 2018

What this PR does / why we need it: Enables the remaining --oidc options to be user-overridable.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2112

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

k8s apiserver --oidc properties are user-overridable

@ghost ghost assigned jackfrancis Apr 5, 2018
@ghost ghost added the in progress label Apr 5, 2018
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackfrancis jackfrancis merged commit 3e07cc0 into Azure:master Apr 5, 2018
@ghost ghost removed the in progress label Apr 5, 2018
@jackfrancis jackfrancis deleted the oidc-user-override branch April 5, 2018 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable OIDC options as user-configurable
2 participants