Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Enable OIDC options as user-configurable #2112

Closed
mwieczorek opened this issue Jan 22, 2018 · 6 comments · Fixed by #2603
Closed

Enable OIDC options as user-configurable #2112

mwieczorek opened this issue Jan 22, 2018 · 6 comments · Fixed by #2603
Assignees

Comments

@mwieczorek
Copy link

Is this a request for help?:


Is this an ISSUE or FEATURE REQUEST? (choose one):
FEATURE REQUEST

What version of acs-engine?:
0.12.0

Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes

According to https://github.com/Azure/acs-engine/blob/master/docs/clusterdefinition.md
OIDC options (--oidc-username-claim, --oidc-groups-claim, --oidc-client-id, --oidc-issuer-url) for apiserver config

are not currently user-configurable, either because a higher order configuration vector is available that enforces kubelet configuration, or because a static configuration is required to build a functional cluster

Is it possible to change that and make them user-configurable?
Possible use case is if I don't want to use AAD but f.e. dex instead.
I know that it's related to AADProfile, and of course in case AADProfile is set it could take precedence.

@mwieczorek
Copy link
Author

Hi, any thoughts about this? I'm just asking if you would consider such change and eventually PR?

@mwieczorek
Copy link
Author

@CecileRobertMichon @jackfrancis sorry to bother you directly, but could you please take a look and write what do you think?

@mwieczorek
Copy link
Author

Trying to gain attention once again :)
@jackfrancis @CecileRobertMichon

@jackfrancis
Copy link
Member

Thanks for your patience, @mwieczorek, this PR (merged) actually addressed some of the above properties:

9751705

I'd be happy to move over the remaining. What are your thoughts on the current state of these properties in master?

@mwieczorek
Copy link
Author

@jackfrancis
I haven't seen #2528 yet. Great, so I need just two more: --oidc-client-id, --oidc-issuer-url.

@mwieczorek
Copy link
Author

@jackfrancis
I've seen #2528 is released (https://github.com/Azure/acs-engine/releases/tag/v0.15.0).
I'll be happy if the second part (--oidc-client-id, --oidc-issuer-url) ships in v0.16.0 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants