This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Move some AAD args out of the static list #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylr
force-pushed
the
apiserver-args
branch
2 times, most recently
from
42766df to
8f4c7ca
Compare
There are no reasons we should not use user defined values for: --oidc-username-claim --oidc-group-claim Signed-off-by: Sylvain Rabot <[email protected]>
sylr
changed the title
ghost
assigned 
|
Thanks for this @sylr. To explain the reasoning behind the initial implementation: When making these configuration interfaces (kubelet, apiserver, controller-manager, etc) user-configurable and generally, our approach is conservative in terms of exposing something for user-override. Essentially, we default to "static" (i.e. non-user-overridable), and then as use-cases arise for overridable config (such as yours w/ OID user/group claim ids) we evolve the code appropriately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR fixes : fixes #2527