-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): Import Logic Apps from Cloud to Local VSCode #5693
Draft
JoaquimMalcampo
wants to merge
39
commits into
main
Choose a base branch
from
jmalcampo/cloud_to_local
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Cloud to Local Gesture changed package.json and added new file cloudToLocal for button. * Add Cloud to Local Gesture clarified comments in cloudToLocal.ts * feat: Add cloud to local gesture Add a button to the front end to enable cloud functionality. * feat(vscode/design/Cloud to Local): Added a button for cloud to local and skeleton of the command * feat(vscode): Add button to take zipped Logic App from the desktop and unzip to the local workspace * fix(vscode): fixed naming of menu item * fix(vscode): Changed to single function call * feat(vscode): Made merging of local.settings.json * fix(vscode): Changed bundle and script settings to prioritize LA
* Add Cloud to Local Gesture changed package.json and added new file cloudToLocal for button. * Add Cloud to Local Gesture clarified comments in cloudToLocal.ts * feat: Add cloud to local gesture Add a button to the front end to enable cloud functionality. * feat(vscode/design/Cloud to Local): Added a button for cloud to local and skeleton of the command * feat(vscode): Add button to take zipped Logic App from the desktop and unzip to the local workspace * fix(vscode): fixed naming of menu item * fix(vscode): Changed to single function call * feat(vscode): Made merging of local.settings.json * fix(vscode): Changed bundle and script settings to prioritize LA * fix(vscode): Branch is messed up, trying to fix * feat(vscode): parameters changed to raw/key and organized cloudToLocal * fix(vscode): Remove duplicate deepMerge function * fix(vscode): added tests, changed connections to work with cloudtolocal and 2 new functions. * fix(vscode): changed the deepmerge into extend because there are test for it already * fix(vscode): removed static tenant Id, used parameterFileName import, fixed connectionsData in case empty, removed console.log, and used for..of instead of forEach
This reverts commit 95920db.
* Add Cloud to Local Gesture changed package.json and added new file cloudToLocal for button. * Add Cloud to Local Gesture clarified comments in cloudToLocal.ts * feat: Add cloud to local gesture Add a button to the front end to enable cloud functionality. * feat(vscode/design/Cloud to Local): Added a button for cloud to local and skeleton of the command * feat(vscode): Add button to take zipped Logic App from the desktop and unzip to the local workspace * fix(vscode): fixed naming of menu item * fix(vscode): Changed to single function call * feat(vscode): Made merging of local.settings.json * fix(vscode): Changed bundle and script settings to prioritize LA
* Add Cloud to Local Gesture changed package.json and added new file cloudToLocal for button. * Add Cloud to Local Gesture clarified comments in cloudToLocal.ts * feat: Add cloud to local gesture Add a button to the front end to enable cloud functionality. * feat(vscode/design/Cloud to Local): Added a button for cloud to local and skeleton of the command * feat(vscode): Add button to take zipped Logic App from the desktop and unzip to the local workspace * fix(vscode): fixed naming of menu item * fix(vscode): Changed to single function call * feat(vscode): Made merging of local.settings.json * fix(vscode): Changed bundle and script settings to prioritize LA * fix(vscode): Branch is messed up, trying to fix * feat(vscode): parameters changed to raw/key and organized cloudToLocal * fix(vscode): Remove duplicate deepMerge function * fix(vscode): added tests, changed connections to work with cloudtolocal and 2 new functions. * fix(vscode): changed the deepmerge into extend because there are test for it already * fix(vscode): removed static tenant Id, used parameterFileName import, fixed connectionsData in case empty, removed console.log, and used for..of instead of forEach
…ogicAppsUX into jmalcampo/cloud_to_local
lambrianmsft
requested changes
Sep 17, 2024
apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ZipFileStep.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ZipFileStep.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ZipFileStep.ts
Outdated
Show resolved
Hide resolved
ccastrotrejo
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes
mireedmsft
approved these changes
Sep 17, 2024
apps/vs-code-designer/src/app/commands/createNewCodeProject/__test__/cloudToLocal.test.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewProject/createProjectSteps/ZipFileStep.ts
Outdated
Show resolved
Hide resolved
@JoaquimMalcampo Is this PR still relevant or do you think we can close it? |
Yes this is a new feature slated for release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement Checklist
Type of Change
Current Behavior
Extending @Jaden-Codes project.
New Behavior
Includes reformatting and support for handling parameterized connections.
Impact of Change
Screenshots or Videos (if applicable)