-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vscode): Developing Cloud to Local feature #5046
Merged
ccastrotrejo
merged 18 commits into
Azure:dev/cloud
from
Jaden-Codes:AddCloudtoLocalGesture
Jul 19, 2024
Merged
feat(vscode): Developing Cloud to Local feature #5046
ccastrotrejo
merged 18 commits into
Azure:dev/cloud
from
Jaden-Codes:AddCloudtoLocalGesture
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed package.json and added new file cloudToLocal for button.
clarified comments in cloudToLocal.ts
Add a button to the front end to enable cloud functionality.
… and skeleton of the command
…d unzip to the local workspace
…es/LogicAppsUX into AddCloudtoLocalGesture
Jaden-Codes
changed the title
Add cloud to local gesture
fix(vscode): trying to organize branch
Jun 28, 2024
ccastrotrejo
approved these changes
Jul 3, 2024
ccastrotrejo
requested changes
Jul 3, 2024
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
mireedmsft
approved these changes
Jul 5, 2024
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
…al and 2 new functions.
ccastrotrejo
requested changes
Jul 19, 2024
apps/vs-code-designer/src/app/commands/createNewCodeProject/__test__/cloudToLocal.test.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocal.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/createNewCodeProject/cloudToLocalHelper.ts
Outdated
Show resolved
Hide resolved
@Jaden-Codes could you also update the PR title to something that describes the intended changes |
Jaden-Codes
changed the title
fix(vscode): trying to organize branch
feat(vscode): Developing Cloud to Local feature
Jul 19, 2024
… fixed connectionsData in case empty, removed console.log, and used for..of instead of forEach
ccastrotrejo
approved these changes
Jul 19, 2024
JoaquimMalcampo
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Add Cloud to Local Gesture changed package.json and added new file cloudToLocal for button. * Add Cloud to Local Gesture clarified comments in cloudToLocal.ts * feat: Add cloud to local gesture Add a button to the front end to enable cloud functionality. * feat(vscode/design/Cloud to Local): Added a button for cloud to local and skeleton of the command * feat(vscode): Add button to take zipped Logic App from the desktop and unzip to the local workspace * fix(vscode): fixed naming of menu item * fix(vscode): Changed to single function call * feat(vscode): Made merging of local.settings.json * fix(vscode): Changed bundle and script settings to prioritize LA * fix(vscode): Branch is messed up, trying to fix * feat(vscode): parameters changed to raw/key and organized cloudToLocal * fix(vscode): Remove duplicate deepMerge function * fix(vscode): added tests, changed connections to work with cloudtolocal and 2 new functions. * fix(vscode): changed the deepmerge into extend because there are test for it already * fix(vscode): removed static tenant Id, used parameterFileName import, fixed connectionsData in case empty, removed console.log, and used for..of instead of forEach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a new feature that unzips files and alters settings to make a logic app run on VSCode from Cloud.
What is the current behavior? (You can also link to an open issue here)
The current behavior is unzipping a logic app, taking out settings from connections and adding Auth types to parameters.
What is the new behavior (if this is a feature change)?
The new behavior allows users to unzip files and configure settings for running a logic app on VSCode from the Cloud.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, this PR does not introduce any breaking changes.
Please Include Screenshots or Videos of the intended change:
CloudToLocal.Test.mp4