Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Developing Cloud to Local feature #5046

Merged
merged 18 commits into from
Jul 19, 2024

Conversation

Jaden-Codes
Copy link

@Jaden-Codes Jaden-Codes commented Jun 28, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This is a new feature that unzips files and alters settings to make a logic app run on VSCode from Cloud.

  • What is the current behavior? (You can also link to an open issue here)
    The current behavior is unzipping a logic app, taking out settings from connections and adding Auth types to parameters.

  • What is the new behavior (if this is a feature change)?
    The new behavior allows users to unzip files and configure settings for running a logic app on VSCode from the Cloud.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No, this PR does not introduce any breaking changes.

  • Please Include Screenshots or Videos of the intended change:

CloudToLocal.Test.mp4

@Jaden-Codes Jaden-Codes changed the title Add cloud to local gesture fix(vscode): trying to organize branch Jun 28, 2024
@Jaden-Codes Jaden-Codes reopened this Jun 28, 2024
@ccastrotrejo ccastrotrejo changed the base branch from main to dev/cloud June 29, 2024 00:51
@ccastrotrejo
Copy link
Contributor

@Jaden-Codes could you also update the PR title to something that describes the intended changes

@Jaden-Codes Jaden-Codes changed the title fix(vscode): trying to organize branch feat(vscode): Developing Cloud to Local feature Jul 19, 2024
… fixed connectionsData in case empty, removed console.log, and used for..of instead of forEach
@Jaden-Codes Jaden-Codes requested a review from ccastrotrejo July 19, 2024 22:06
@ccastrotrejo ccastrotrejo merged commit 8535e9b into Azure:dev/cloud Jul 19, 2024
8 of 9 checks passed
JoaquimMalcampo pushed a commit that referenced this pull request Sep 9, 2024
* Add Cloud to Local Gesture
changed package.json and added
new file cloudToLocal for button.

* Add Cloud to Local Gesture
clarified comments in cloudToLocal.ts

* feat: Add cloud to local gesture
Add a button to the front end to enable cloud functionality.

* feat(vscode/design/Cloud to Local): Added a button for cloud to local and skeleton of the command

* feat(vscode): Add button to take zipped Logic App from the desktop and unzip to the local workspace

* fix(vscode): fixed naming of menu item

* fix(vscode): Changed to single function call

* feat(vscode): Made merging of local.settings.json

* fix(vscode): Changed bundle and script settings to prioritize LA

* fix(vscode): Branch is messed up, trying to fix

* feat(vscode): parameters changed to raw/key and organized cloudToLocal

* fix(vscode): Remove duplicate deepMerge function

* fix(vscode): added tests, changed connections to work with cloudtolocal and 2 new functions.

* fix(vscode): changed the deepmerge into extend because there are test for it already

* fix(vscode): removed static tenant Id, used parameterFileName import, fixed connectionsData in case empty, removed console.log, and used for..of instead of forEach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants