Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADT Explorer bugfixes and updates #227

Merged
merged 14 commits into from
Nov 3, 2021
Merged

ADT Explorer bugfixes and updates #227

merged 14 commits into from
Nov 3, 2021

Conversation

ccrowley96
Copy link
Contributor

@ccrowley96 ccrowley96 commented Oct 27, 2021

ADO listed Bug fixes

  • Fixes REST error when landing in explorer for the first time. Users can no longer cancel out of the ADT URL picker dialogue before selecting an instance URL. Also removed the call to query models on initial load when no URL is selected. (ADO item)
  • Model Graph inheritance lines no longer display implied inheritance. Added logic to slice only the first base model when drawing inheritance lines on the model graph. (ADO item)
  • Updated model graph 'Run Layout' button to 'Choose layout' with correct icon. (ADO item)
  • Fixed bug where model refresh button did nothing. This was happening when caching was enabled. The cached models would be hit and no refresh was executed. These changes add a forced cache bypass to this button - forcing a refresh. (ADO item)
  • Fixed issue where clicking 'Run query' from the model graph had no effect and was confusing to users. Now, when a user runs a query from the model graph, it snaps back to the twin graph and executes the query. (ADO item)
  • Fixed issue where ADT URL configuration was not saving when local storage cleared. URL configuration is now also stored in app state and only seeded by local storage - this should fix the multi-tab configuration issue users are facing. (ADO item)
  • Updated caching to default OFF (ADO item)

Comparison of model graph inheritance and component line changes

Before

image

After

image

GitHub issue bug fixes

New features

Model upload confirmation

Added model upload confirmation message bar and info dialogue. Clicking view details on the success message bar opens the dialogue showing the details of the uploaded models. The success message bar dismisses after 15 seconds.

image

Visual changes

Updated panel tabs to Fluent style with lighter background. This helps to clarify what tab is selected and makes their tab nature more apparent.

image

Fixed high-contrast mode toggle UI.

Before

image

After

image

@ccrowley96 ccrowley96 linked an issue Oct 28, 2021 that may be closed by this pull request
@ccrowley96 ccrowley96 changed the title Oct / Nov bugfixes ADT Explorer bugfixes and updates Oct 29, 2021
@ccrowley96 ccrowley96 marked this pull request as ready for review October 29, 2021 18:35
Copy link
Collaborator

@niusoff niusoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! The one thing I noticed when playing around with it is an accessibility bug that appears to be present in prod as well, so, it's not a regression - there appears to be some issues with tabbing into/out of the "twin graph" and "model graph" tab buttons. Can repro by clicking on one of them, hitting tab, then shift tab and you can see the focus jump from the "model graph" button to the previous thing in the tab order. Not sure what's triggering this

@ccrowley96
Copy link
Contributor Author

Overall looks great! The one thing I noticed when playing around with it is an accessibility bug that appears to be present in prod as well, so, it's not a regression - there appears to be some issues with tabbing into/out of the "twin graph" and "model graph" tab buttons. Can repro by clicking on one of them, hitting tab, then shift tab and you can see the focus jump from the "model graph" button to the previous thing in the tab order. Not sure what's triggering this

I think the Fluent UI Pivot Items (tabs) and command bars use arrow keys to navigate within their tab group rather than tab / shift tab. So this might not be a bug, not positive I'm reproing what you hit though.

@ccrowley96 ccrowley96 merged commit e561d14 into main Nov 3, 2021
@ccrowley96 ccrowley96 deleted the cocrowle-bugfixes branch November 3, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants