-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADT Explorer bugfixes and updates #227
Conversation
…lag to only show components present on the same model
… Use this flag to only show components present on the same model
…n of inherited model rather than base model
client/src/components/ModelGraphViewerComponent/ModelGraphViewerComponent.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! The one thing I noticed when playing around with it is an accessibility bug that appears to be present in prod as well, so, it's not a regression - there appears to be some issues with tabbing into/out of the "twin graph" and "model graph" tab buttons. Can repro by clicking on one of them, hitting tab, then shift tab and you can see the focus jump from the "model graph" button to the previous thing in the tab order. Not sure what's triggering this
I think the Fluent UI Pivot Items (tabs) and command bars use arrow keys to navigate within their tab group rather than tab / shift tab. So this might not be a bug, not positive I'm reproing what you hit though. |
ADO listed Bug fixes
Comparison of model graph inheritance and component line changes
Before
After
GitHub issue bug fixes
New features
Model upload confirmation
Added model upload confirmation message bar and info dialogue. Clicking view details on the success message bar opens the dialogue showing the details of the uploaded models. The success message bar dismisses after 15 seconds.
Visual changes
Updated panel tabs to Fluent style with lighter background. This helps to clarify what tab is selected and makes their tab nature more apparent.
Fixed high-contrast mode toggle UI.
Before
After