Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover pop-up for twin shows description from top level extended model #226

Closed
packnologyusa opened this issue Oct 27, 2021 · 0 comments · Fixed by #227
Closed

Hover pop-up for twin shows description from top level extended model #226

packnologyusa opened this issue Oct 27, 2021 · 0 comments · Fixed by #227
Labels
bug Something isn't working

Comments

@packnologyusa
Copy link

If a model (B) extends another model (A), when you hover over a twin of model B it shows the description from model A. If a model (C) extends model B then it will still show the description for model A. Please see screenshots showing a concrete example where model "orchard" extends "addressable" which extends "geolocatable", hovering over an orchard twin shows the description from the geolocatable model.
Capture_ADTE_twin_description_wrong_model
Capture_ADTE_twin_description_wrong_model_info
Capture_ADTE_twin_description_wrong_model_info_addressable
Capture_ADTE_twin_description_wrong_model_info_geolocatable
ccrowley96 added a commit that referenced this issue Oct 28, 2021
@ccrowley96
Fixes #226 - hovering over twin would show displayName and descriptio…
d1c13bd 
…n of inherited model rather than base model
@ccrowley96 ccrowley96 linked a pull request Oct 28, 2021 that will close this issue
ADT Explorer bugfixes and updates #227
Merged
@ccrowley96 ccrowley96 added the bug Something isn't working label Oct 28, 2021
@ccrowley96 ccrowley96 mentioned this issue Oct 29, 2021
Merged
ccrowley96 added a commit that referenced this issue Nov 3, 2021
@ccrowley96
fix: ADT Explorer bugfixes and updates (#227)
e561d14 
* Fixes a number of bugs filed in ADO for the explorer

* Increased icon contast for control toolbars;  changed default to caching off

* Only show first inheritance base in model graph viewer

* Updated AdtUrl configuration logic

* Fixed toggle colors in high contrast mode

* Changed favicon.ico to favicon.png

* Added flag to components to indicate if they are extended.  Use this flag to only show components present on the same model

* Fixes #182 Added flag to components to indicate if they are extended.  Use this flag to only show components present on the same model

* Fixes #226 - hovering over twin would show displayName and description of inherited model rather than base model

* Added model upload result message bar and modal with details on uploaded data

* CR fixes

* Bumped cardboard dep to fix schemas referencing issue in PI

* Fixed tab order bug with model relationships toggle panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ADT Explorer bugfixes and updates Azure-Samples/digital-twins-explorer
2 participants
@ccrowley96 @packnologyusa