feat: Removing `is_dev_net` flag #8275

LHerskind · 2024-08-29T17:44:07Z

This PR tries to get rid of the is_dev_net flag that we had in the constants.nr. This is to simplify the flows such that is just one flow used by both the devnet and spartan.

Alters our createNode and setup such that they will always assume active validators, since it will be required for proper sequencing.

Changes the l1-publisher slightly to reduce the probability that validateBlockForSubmission would fail due to an Ethereum block arriving between the check and the propose call.

Alters the sequencer::work() function such that there is a cleaner split between when we can return early, and when we have to throw an error and revert to properly rollback the global state.

Alters the collectAttestations functions slightly, i) to cover the case where a validator client is not provided but a committee is needed, and ii) to ensure that the sequencers own attestation also makes it way into the attestations collected.

Graveyard

Below this point is the graveyard where old issues very talked about and insanity ensued.

Currently running into issues where tests are behaving "strange". Namely, it seems like we sometimes will have a passing test and sometimes wont.

This especially is encountered when many tests are run at once, such as the e2e_token_contract tests. A snippet below shares some frustration. If we are running all the tests, they always fail, but if running only some, it seems to depend on what is being logged...

DEBUG="aztec:*,-aztec:avm_simulator:*" LOG_LEVEL="silent" yarn test e2e_token_contract/transfer_private // passes
LOG_LEVEL="silent" yarn test e2e_token_contract/transfer_private // fails
LOG_LEVEL="DEBUG" yarn test e2e_token_contract/transfer_private // fails

Somewhat interesting, if using AZTEC_SLOT_DURATION = 36 many of these issues seems to go away, e.g., transactions are not dropped anymore etc. However, this really should not be the case, hence this time influence is not walltime, as it is using an anvil instance behind the scenes. Main reason around this is more likely to be that we don't encounter the case where a submitProof have progressed time and moved the slot.

Looking at logs!

What do I see in the logs

Transaction TX_A is dropped.
When looking higher, I can see that TX_A is dropped because of duplicate nullifiers in the state trees! Something interesting! While the nullifier tree from sync is size 1088, the one we match against is 1216 and the index of first collisions is OUTSIDE of the tree that you get from synching 💀
Looking JUST above where we drop these transactions i see that we are encountering an error while perfoming validateHeader (the slot have changed because of submitProof)
Looking slightly above this, we can see what I believe is the sequencer simulating the base rollups (all good here!)
Moving slightly up, we can see that the sequencer is processing the transaction itself.
Further up, we see the user creating the transaction
And above that we see the last block, lets call it BLOCK_A

Note from this: There is no block after BLOCK_A where TX_A could have been included, but when the sequencer is FAILING to publish the new block, it seems to be keeping the state but dropping the block AND its transactions. So the setup fails because the user will get the response from the node that "this is a double-spend, go away".

I tried using PROVER_NODE_DISABLE_AUTOMATIC_PROVING to turn of the proving, but that don't seem to have any effect, and if I try to just bypass the submitProofs it seems to cause the application to infinite loop where it just never tries anything ever again.

The tree that the sequencer is checking against that is larger than what you get from sync seem to only be larger for a "short" time before it figures out something is messed up, and will "rollback", but the damage is done and we just dropped potentially a lot of transactions

There exact timing of the failure also "depends", so that is kinda pain.

Update:
Issue seemed to be that if we returned early from work() in the sequencer, when not proposing a block. We would not rollback the state, so if state changes were made, it would WRECK the next block.

LHerskind · 2024-08-29T17:44:20Z

feat: Removing is_dev_net flag #8275 👈
chore: rename process to propose for clarity #8265
feat: moving fee payout + make proof submission sequential #8262
feat: l1-publisher cleanup #8148
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

AztecBot · 2024-08-30T11:24:10Z

Benchmark results

Metrics with a significant change:

app_circuit_witness_generation_time_in_ms (SchnorrAccount:entrypoint): 449 (+17%)
avm_simulation_time_ms (Token:mint_public): 492 (+58%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,743	1,557	714 (+1%)	780 (+3%)	773
proof_construction_time_sha256_30_ms	11,450 (-1%)	3,091	1,379	1,427	1,478 (+1%)
proof_construction_time_sha256_100_ms	44,176	11,855	5,490 (+1%)	5,912 (+9%)	5,419 (-9%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	57.0	88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,530	422	203	228 (+2%)	271
proof_construction_time_poseidon_hash_100_ms	5,645	1,508	676	728	750 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,220	92,992	178,120
l1_rollup_execution_gas	843,039	1,576,707	3,361,891
l2_block_processing_time_in_ms	259 (+2%)	453 (+3%)	816 (+1%)
l2_block_building_time_in_ms	11,369	22,263 (-1%)	44,330 (-1%)
l2_block_rollup_simulation_time_in_ms	11,368	22,263 (-1%)	44,329 (-1%)
l2_block_public_tx_process_time_in_ms	9,676	20,560 (-1%)	42,601 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,035 (+3%)	3,932 (+3%)
node_database_size_in_bytes	12,681,296	16,765,008
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	93.7 (+2%)	382 (-2%)	21,474	44,898	N/A
private-kernel-inner	177 (-1%)	683 (+1%)	72,411	45,020	N/A
private-kernel-reset-tiny	327 (+5%)	704 (+1%)	65,240	44,886	N/A
private-kernel-tail	174 (+4%)	135 (+4%)	50,608	52,921	N/A
base-parity	5.56	N/A	160	96.0	N/A
root-parity	35.2	N/A	73,948	96.0	N/A
base-rollup	2,653 (-4%)	N/A	189,154	664	N/A
block-root-rollup	43.0 (+5%)	N/A	58,205	2,448	N/A
public-kernel-setup	84.0	N/A	105,085	71,222	N/A
public-kernel-app-logic	97.9	N/A	104,895	71,222	N/A
public-kernel-tail	850 (-1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	307 (-1%)	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	775	590	455,400	1,825	N/A
public-kernel-teardown	84.4 (+1%)	N/A	105,349	71,222	N/A
merge-rollup	20.4 (+2%)	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	82,357 (+1%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	339 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.1
MultiCallEntrypoint:entrypoint	1,920	11,731	401
FeeJuice:deploy	1,376	11,731	386 (-2%)
SchnorrAccount:constructor	1,312	11,731	72.3 (-1%)
SchnorrAccount:entrypoint	2,336	11,731	⚠️ 449 (+17%)
FeeJuice:claim	1,344	11,731	37.6 (+3%)
Token:privately_mint_private_note	1,280	11,731	100 (-6%)
FPC:fee_entrypoint_public	1,344	11,731	26.2
Token:transfer	1,312	11,731	222
Benchmarking:create_note	1,344	11,731	105 (+25%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.4 (-1%)
Token:unshield	1,376	11,731	515 (-1%)
FPC:fee_entrypoint_private	1,376	11,731	693 (-1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	49.7 (+4%)	8,174
FeeJuice:set_portal	11.3 (+5%)	4,055
Token:constructor	82.3 (-6%)	29,082
FPC:constructor	55.7	18,940
FeeJuice:check_balance	38.0	5,978
Token:mint_public	⚠️ 492 (+58%)	12,704
Token:assert_minter_and_mint	48.7 (+3%)	8,467
AuthRegistry:set_authorized	41.1 (-12%)	4,194
FPC:prepare_fee	251 (-4%)	6,747
Token:transfer_public	26.6 (-1%)	39,863
FPC:pay_refund	54.3	9,398
Benchmarking:increment_balance	1,218 (-1%)	7,263
Token:_increase_public_balance	40.2 (-9%)	8,686
FPC:pay_refund_with_shielded_rebate	60.6 (-1%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.161 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.16 (+1%)	3.86	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.112 (+1%)	0.109 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.1 (+1%)	17.7 (+2%)	30.7	59.9 (+4%)	112 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.106 (+1%)	0.103 (+2%)	0.100	0.103 (+4%)	0.101 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.6 (+1%)	25.7	43.9 (+1%)	83.5 (+3%)	165 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	108	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.112 (+2%)	0.103	0.106 (+1%)	0.103 (+3%)	0.103 (+2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.6 (+2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	131	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107 (+1%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,838	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

LHerskind · 2024-08-30T16:47:24Z

Will add an extra test to make sure that single sequencer node running walltime anvil will work to ensure that it is not something that could break devnet.

Maddiaa0

well documented, good stuff man

Maddiaa0 · 2024-08-30T16:18:07Z

l1-contracts/src/core/Rollup.sol

-      revert Errors.DevNet__NoPruningAllowed();
-    }
-
+  function prune() external override(IRollup) onlyOwner {


will we need an issue to deactivate this guard? maybe not if its a debugging thing anyway

All of the onlyOwner should go away when we move out of spartan so think it is ok to have it here 🤷

Maddiaa0 · 2024-08-30T17:42:53Z

yarn-project/end-to-end/src/e2e_devnet.test.ts

+  const submitTxsTo = async (pxe: PXEService, numTxs: number) => {
+    const txs: SentTx[] = [];
+    for (let i = 0; i < numTxs; i++) {
+      // const tx = getSchnorrAccount(pxe, Fr.random(), GrumpkinScalar.random(), Fr.random()).deploy();


Maddiaa0 · 2024-08-30T17:43:39Z

yarn-project/end-to-end/src/e2e_p2p_network.test.ts

-    }
-
-    ({ teardown, config, logger } = await setup(0, { initialValidators, ...options }));
+    ({ teardown, config, logger, deployL1ContractsValues } = await setup(0, { initialValidators, ...options }));


i wonder if setup even needs initial validators if it will always contain a single one

It will not always contain a single, it will just allow anyone if no initial. For this test, think we will also need to alter it when using larger slots. At least I ran into issues when using a walltime and aztec_slot_duration > ethereum_slot_duration.

Maddiaa0 · 2024-08-30T17:48:46Z

yarn-project/end-to-end/src/e2e_p2p_network.test.ts

+
+    //@note   Now we jump ahead to the next epoch such that the validator committee is picked
+    //        INTERVAL MINING: If we are using anvil interval mining this will NOT progress the time!
+    //        Which means that the validator set will still be empty! So anyone can propose.


good note, i previously got tripped up here

Maddiaa0 · 2024-08-30T17:49:14Z

yarn-project/end-to-end/src/fixtures/utils.ts

@@ -300,6 +300,8 @@ type SetupOptions = {
  salt?: number;
  /** An initial set of validators */
  initialValidators?: EthAddress[];
+  /** Anvil block time (interval) */


Maddiaa0 · 2024-08-30T17:55:05Z

yarn-project/sequencer-client/src/sequencer/sequencer.test.ts


  beforeEach(() => {
    lastBlockNumber = 0;

    block = L2Block.random(lastBlockNumber + 1);

+    mockedGlobalVariables = new GlobalVariables(


https://www.youtube.com/watch?v=XTjJ2_P5P4U

Maddiaa0 · 2024-08-30T17:57:57Z

yarn-project/sequencer-client/src/sequencer/sequencer.ts

+    try {
+      // @note  It is very important that the following function will FAIL and not just return early
+      //        if it have made any state changes. If not, we won't rollback the state, and you will
+      //        be in for a world of pain.


bit dramatic m8

Maddiaa0 · 2024-08-30T17:59:27Z

yarn-project/sequencer-client/src/sequencer/sequencer.ts

    // TODO(https://github.com/AztecProtocol/aztec-packages/issues/7962): inefficient to have a round trip in here - this should be cached
    const committee = await this.publisher.getCurrentEpochCommittee();

    if (committee.length === 0) {
      return undefined;
+    } else {


does this need to be nested in the else if the if is a guard

Probably not lmao.

* master: git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg chore(revert): earthfile accidental change (#8309) chore: fix warnings in `avm-transpiler` (#8307) refactor(bb): more graceful pippenger on non-powers-of-2 (#8279) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg feat: Removing `is_dev_net` flag (#8275)

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.52.0</summary> ## [0.52.0](aztec-package-v0.51.1...aztec-package-v0.52.0) (2024-09-01) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.52.0</summary> ## [0.52.0](barretenberg.js-v0.51.1...barretenberg.js-v0.52.0) (2024-09-01) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.52.0</summary> ## [0.52.0](aztec-packages-v0.51.1...aztec-packages-v0.52.0) (2024-09-01) ### ⚠ BREAKING CHANGES * Check unused generics are bound (noir-lang/noir#5840) ### Features * Add `Expr::as_assert` (noir-lang/noir#5857) ([cf5b667](cf5b667)) * Add `Expr::resolve` and `TypedExpr::as_function_definition` (noir-lang/noir#5859) ([cf5b667](cf5b667)) * Add `FunctionDef::body` (noir-lang/noir#5825) ([cf5b667](cf5b667)) * Add `FunctionDef::has_named_attribute` (noir-lang/noir#5870) ([cf5b667](cf5b667)) * Add `Type::as_string` (noir-lang/noir#5871) ([cf5b667](cf5b667)) * Clarify state in Protogalaxy 3 ([#8181](#8181)) ([4a9bb9d](4a9bb9d)) * LSP signature help for assert and assert_eq (noir-lang/noir#5862) ([cf5b667](cf5b667)) * **meta:** Comptime keccak (noir-lang/noir#5854) ([cf5b667](cf5b667)) * **optimization:** Avoid merging identical (by ID) arrays (noir-lang/noir#5853) ([cf5b667](cf5b667)) * **perf:** Simplify poseidon2 cache zero-pad (noir-lang/noir#5869) ([cf5b667](cf5b667)) * Populate epoch 0 from initial validator set ([#8286](#8286)) ([cbdec54](cbdec54)) * Remove unnecessary copying of vector size during reversal (noir-lang/noir#5852) ([cf5b667](cf5b667)) * Removing `is_dev_net` flag ([#8275](#8275)) ([fc1f307](fc1f307)) * Show backtrace on comptime assertion failures (noir-lang/noir#5842) ([cf5b667](cf5b667)) * Simplify constant calls to `poseidon2_permutation`, `schnorr_verify` and `embedded_curve_add` (noir-lang/noir#5140) ([cf5b667](cf5b667)) * Sync from aztec-packages (noir-lang/noir#5790) ([cf5b667](cf5b667)) * Warn on unused imports (noir-lang/noir#5847) ([cf5b667](cf5b667)) ### Bug Fixes * Check unused generics are bound (noir-lang/noir#5840) ([cf5b667](cf5b667)) * Enforce parity of sequencer tx validation and node tx validation ([#7951](#7951)) ([c7eaf92](c7eaf92)) * Make simulations validate resulting tx by default ([#8157](#8157)) ([f5e388d](f5e388d)) * **nargo:** Resolve Brillig assertion payloads (noir-lang/noir#5872) ([cf5b667](cf5b667)) * Prevent honk proof from getting stale inputs on syncs ([#8293](#8293)) ([2598108](2598108)) * Remove fee juice mint public ([#8260](#8260)) ([2395af3](2395af3)) * **sha256:** Add extra checks against message size when constructing msg blocks (noir-lang/noir#5861) ([cf5b667](cf5b667)) * **sha256:** Fix upper bound when building msg block and delay final block compression under certain cases (noir-lang/noir#5838) ([cf5b667](cf5b667)) * **sha256:** Perform compression per block and utilize ROM instead of RAM when setting up the message block (noir-lang/noir#5760) ([cf5b667](cf5b667)) ### Miscellaneous * Add documentation to `to_be_bytes`, etc. (noir-lang/noir#5843) ([cf5b667](cf5b667)) * Add missing cases to arithmetic generics (noir-lang/noir#5841) ([cf5b667](cf5b667)) * Add test to reproduce [#8306](#8306) ([41d418c](41d418c)) * Alert slack on Sepolia test ([#8263](#8263)) ([6194b94](6194b94)) * **bb:** Make compile on stock mac clang ([#8278](#8278)) ([7af80ff](7af80ff)) * **bb:** More graceful pippenger on non-powers-of-2 ([#8279](#8279)) ([104ea85](104ea85)) * Bump noir-bignum to 0.3.2 ([#8276](#8276)) ([4c6fe1a](4c6fe1a)) * **ci:** Try to debug 'command brotli not found' ([#8305](#8305)) ([9ee8dd6](9ee8dd6)) * Don't require empty `Prover.toml` for programs with zero arguments but a return value (noir-lang/noir#5845) ([cf5b667](cf5b667)) * Fix a bunch of generics issues in aztec-nr ([#8295](#8295)) ([6e84970](6e84970)) * Fix more issues with generics ([#8302](#8302)) ([4e2ce80](4e2ce80)) * Fix warnings in `avm-transpiler` ([#8307](#8307)) ([359fe05](359fe05)) * Introduce the Visitor pattern (noir-lang/noir#5868) ([cf5b667](cf5b667)) * **perf:** Simplify poseidon2 algorithm (noir-lang/noir#5811) ([cf5b667](cf5b667)) * **perf:** Update to stdlib keccak for reduced Brillig code size (noir-lang/noir#5827) ([cf5b667](cf5b667)) * Redo typo PR by nnsW3 (noir-lang/noir#5834) ([cf5b667](cf5b667)) * Renaming around Protogalaxy Prover ([#8272](#8272)) ([be2169d](be2169d)) * Replace relative paths to noir-protocol-circuits ([56e3fbf](56e3fbf)) * Replace relative paths to noir-protocol-circuits ([1b245c4](1b245c4)) * Replace relative paths to noir-protocol-circuits ([9c3bc43](9c3bc43)) * **revert:** Earthfile accidental change ([#8309](#8309)) ([2d3e0b6](2d3e0b6)) * Underconstrained check in parallel (noir-lang/noir#5848) ([cf5b667](cf5b667)) ### Documentation * **bb:** Transcript spec ([#8301](#8301)) ([18abf37](18abf37)) </details> <details><summary>barretenberg: 0.52.0</summary> ## [0.52.0](barretenberg-v0.51.1...barretenberg-v0.52.0) (2024-09-01) ### Features * Clarify state in Protogalaxy 3 ([#8181](#8181)) ([4a9bb9d](4a9bb9d)) ### Bug Fixes * Prevent honk proof from getting stale inputs on syncs ([#8293](#8293)) ([2598108](2598108)) ### Miscellaneous * **bb:** Make compile on stock mac clang ([#8278](#8278)) ([7af80ff](7af80ff)) * **bb:** More graceful pippenger on non-powers-of-2 ([#8279](#8279)) ([104ea85](104ea85)) * Renaming around Protogalaxy Prover ([#8272](#8272)) ([be2169d](be2169d)) * **revert:** Earthfile accidental change ([#8309](#8309)) ([2d3e0b6](2d3e0b6)) ### Documentation * **bb:** Transcript spec ([#8301](#8301)) ([18abf37](18abf37)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.52.0</summary> ## [0.52.0](AztecProtocol/aztec-packages@aztec-package-v0.51.1...aztec-package-v0.52.0) (2024-09-01) ### Miscellaneous * **aztec-package:** Synchronize aztec-packages versions </details> <details><summary>barretenberg.js: 0.52.0</summary> ## [0.52.0](AztecProtocol/aztec-packages@barretenberg.js-v0.51.1...barretenberg.js-v0.52.0) (2024-09-01) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.52.0</summary> ## [0.52.0](AztecProtocol/aztec-packages@aztec-packages-v0.51.1...aztec-packages-v0.52.0) (2024-09-01) ### ⚠ BREAKING CHANGES * Check unused generics are bound (noir-lang/noir#5840) ### Features * Add `Expr::as_assert` (noir-lang/noir#5857) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add `Expr::resolve` and `TypedExpr::as_function_definition` (noir-lang/noir#5859) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add `FunctionDef::body` (noir-lang/noir#5825) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add `FunctionDef::has_named_attribute` (noir-lang/noir#5870) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add `Type::as_string` (noir-lang/noir#5871) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Clarify state in Protogalaxy 3 ([#8181](AztecProtocol/aztec-packages#8181)) ([4a9bb9d](AztecProtocol/aztec-packages@4a9bb9d)) * LSP signature help for assert and assert_eq (noir-lang/noir#5862) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **meta:** Comptime keccak (noir-lang/noir#5854) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **optimization:** Avoid merging identical (by ID) arrays (noir-lang/noir#5853) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **perf:** Simplify poseidon2 cache zero-pad (noir-lang/noir#5869) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Populate epoch 0 from initial validator set ([#8286](AztecProtocol/aztec-packages#8286)) ([cbdec54](AztecProtocol/aztec-packages@cbdec54)) * Remove unnecessary copying of vector size during reversal (noir-lang/noir#5852) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Removing `is_dev_net` flag ([#8275](AztecProtocol/aztec-packages#8275)) ([fc1f307](AztecProtocol/aztec-packages@fc1f307)) * Show backtrace on comptime assertion failures (noir-lang/noir#5842) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Simplify constant calls to `poseidon2_permutation`, `schnorr_verify` and `embedded_curve_add` (noir-lang/noir#5140) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Sync from aztec-packages (noir-lang/noir#5790) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Warn on unused imports (noir-lang/noir#5847) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) ### Bug Fixes * Check unused generics are bound (noir-lang/noir#5840) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Enforce parity of sequencer tx validation and node tx validation ([#7951](AztecProtocol/aztec-packages#7951)) ([c7eaf92](AztecProtocol/aztec-packages@c7eaf92)) * Make simulations validate resulting tx by default ([#8157](AztecProtocol/aztec-packages#8157)) ([f5e388d](AztecProtocol/aztec-packages@f5e388d)) * **nargo:** Resolve Brillig assertion payloads (noir-lang/noir#5872) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Prevent honk proof from getting stale inputs on syncs ([#8293](AztecProtocol/aztec-packages#8293)) ([2598108](AztecProtocol/aztec-packages@2598108)) * Remove fee juice mint public ([#8260](AztecProtocol/aztec-packages#8260)) ([2395af3](AztecProtocol/aztec-packages@2395af3)) * **sha256:** Add extra checks against message size when constructing msg blocks (noir-lang/noir#5861) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **sha256:** Fix upper bound when building msg block and delay final block compression under certain cases (noir-lang/noir#5838) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **sha256:** Perform compression per block and utilize ROM instead of RAM when setting up the message block (noir-lang/noir#5760) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) ### Miscellaneous * Add documentation to `to_be_bytes`, etc. (noir-lang/noir#5843) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add missing cases to arithmetic generics (noir-lang/noir#5841) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Add test to reproduce [#8306](AztecProtocol/aztec-packages#8306) ([41d418c](AztecProtocol/aztec-packages@41d418c)) * Alert slack on Sepolia test ([#8263](AztecProtocol/aztec-packages#8263)) ([6194b94](AztecProtocol/aztec-packages@6194b94)) * **bb:** Make compile on stock mac clang ([#8278](AztecProtocol/aztec-packages#8278)) ([7af80ff](AztecProtocol/aztec-packages@7af80ff)) * **bb:** More graceful pippenger on non-powers-of-2 ([#8279](AztecProtocol/aztec-packages#8279)) ([104ea85](AztecProtocol/aztec-packages@104ea85)) * Bump noir-bignum to 0.3.2 ([#8276](AztecProtocol/aztec-packages#8276)) ([4c6fe1a](AztecProtocol/aztec-packages@4c6fe1a)) * **ci:** Try to debug 'command brotli not found' ([#8305](AztecProtocol/aztec-packages#8305)) ([9ee8dd6](AztecProtocol/aztec-packages@9ee8dd6)) * Don't require empty `Prover.toml` for programs with zero arguments but a return value (noir-lang/noir#5845) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Fix a bunch of generics issues in aztec-nr ([#8295](AztecProtocol/aztec-packages#8295)) ([6e84970](AztecProtocol/aztec-packages@6e84970)) * Fix more issues with generics ([#8302](AztecProtocol/aztec-packages#8302)) ([4e2ce80](AztecProtocol/aztec-packages@4e2ce80)) * Fix warnings in `avm-transpiler` ([#8307](AztecProtocol/aztec-packages#8307)) ([359fe05](AztecProtocol/aztec-packages@359fe05)) * Introduce the Visitor pattern (noir-lang/noir#5868) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **perf:** Simplify poseidon2 algorithm (noir-lang/noir#5811) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * **perf:** Update to stdlib keccak for reduced Brillig code size (noir-lang/noir#5827) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Redo typo PR by nnsW3 (noir-lang/noir#5834) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) * Renaming around Protogalaxy Prover ([#8272](AztecProtocol/aztec-packages#8272)) ([be2169d](AztecProtocol/aztec-packages@be2169d)) * Replace relative paths to noir-protocol-circuits ([56e3fbf](AztecProtocol/aztec-packages@56e3fbf)) * Replace relative paths to noir-protocol-circuits ([1b245c4](AztecProtocol/aztec-packages@1b245c4)) * Replace relative paths to noir-protocol-circuits ([9c3bc43](AztecProtocol/aztec-packages@9c3bc43)) * **revert:** Earthfile accidental change ([#8309](AztecProtocol/aztec-packages#8309)) ([2d3e0b6](AztecProtocol/aztec-packages@2d3e0b6)) * Underconstrained check in parallel (noir-lang/noir#5848) ([cf5b667](AztecProtocol/aztec-packages@cf5b667)) ### Documentation * **bb:** Transcript spec ([#8301](AztecProtocol/aztec-packages#8301)) ([18abf37](AztecProtocol/aztec-packages@18abf37)) </details> <details><summary>barretenberg: 0.52.0</summary> ## [0.52.0](AztecProtocol/aztec-packages@barretenberg-v0.51.1...barretenberg-v0.52.0) (2024-09-01) ### Features * Clarify state in Protogalaxy 3 ([#8181](AztecProtocol/aztec-packages#8181)) ([4a9bb9d](AztecProtocol/aztec-packages@4a9bb9d)) ### Bug Fixes * Prevent honk proof from getting stale inputs on syncs ([#8293](AztecProtocol/aztec-packages#8293)) ([2598108](AztecProtocol/aztec-packages@2598108)) ### Miscellaneous * **bb:** Make compile on stock mac clang ([#8278](AztecProtocol/aztec-packages#8278)) ([7af80ff](AztecProtocol/aztec-packages@7af80ff)) * **bb:** More graceful pippenger on non-powers-of-2 ([#8279](AztecProtocol/aztec-packages#8279)) ([104ea85](AztecProtocol/aztec-packages@104ea85)) * Renaming around Protogalaxy Prover ([#8272](AztecProtocol/aztec-packages#8272)) ([be2169d](AztecProtocol/aztec-packages@be2169d)) * **revert:** Earthfile accidental change ([#8309](AztecProtocol/aztec-packages#8309)) ([2d3e0b6](AztecProtocol/aztec-packages@2d3e0b6)) ### Documentation * **bb:** Transcript spec ([#8301](AztecProtocol/aztec-packages#8301)) ([18abf37](AztecProtocol/aztec-packages@18abf37)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

This was referenced Aug 29, 2024

feat: l1-publisher cleanup #8148

Merged

feat: moving fee payout + make proof submission sequential #8262

Merged

chore: rename process to propose for clarity #8265

Merged

LHerskind changed the title ~~feat: going insane~~ feat: Removing is_dev_net flag Aug 29, 2024

LHerskind force-pushed the lh/process-becomes-propose branch from 5b614c2 to fea8a7d Compare August 29, 2024 20:58

Base automatically changed from lh/process-becomes-propose to master August 29, 2024 21:33

LHerskind force-pushed the lh/purge-is-dev-net branch from 7b4a5dc to 93bef50 Compare August 30, 2024 10:59

LHerskind force-pushed the lh/purge-is-dev-net branch from 93bef50 to ad57586 Compare August 30, 2024 13:42

LHerskind marked this pull request as ready for review August 30, 2024 14:17

LHerskind requested review from Maddiaa0 and just-mitch August 30, 2024 14:17

LHerskind marked this pull request as draft August 30, 2024 16:47

LHerskind force-pushed the lh/purge-is-dev-net branch from ad57586 to 434aada Compare August 30, 2024 17:24

LHerskind marked this pull request as ready for review August 30, 2024 17:24

Maddiaa0 approved these changes Aug 30, 2024

View reviewed changes

just-mitch approved these changes Aug 30, 2024

View reviewed changes

LHerskind force-pushed the lh/purge-is-dev-net branch from 45e21fa to e55f244 Compare August 30, 2024 19:55

LHerskind added 5 commits August 30, 2024 22:26

feat: purging devnet and fixing work()

fc873cd

chore: address minor issues

d11c0ac

test: add test with walltime anvil

5f97062

chore: address comment + run in ci

a119e01

chore: hans, get ze Flammenwerfer

ed7db37

LHerskind force-pushed the lh/purge-is-dev-net branch from e55f244 to ed7db37 Compare August 30, 2024 22:26

LHerskind merged commit fc1f307 into master Aug 30, 2024
101 checks passed

LHerskind deleted the lh/purge-is-dev-net branch August 30, 2024 23:18

AztecBot mentioned this pull request Aug 30, 2024

chore(master): Release 0.52.0 #8289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Removing `is_dev_net` flag #8275

feat: Removing `is_dev_net` flag #8275

LHerskind commented Aug 29, 2024 •

edited

Loading

LHerskind commented Aug 29, 2024 •

edited

Loading

AztecBot commented Aug 30, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LHerskind commented Aug 30, 2024

Maddiaa0 left a comment

Maddiaa0 Aug 30, 2024

LHerskind Aug 30, 2024

Maddiaa0 Aug 30, 2024

Maddiaa0 Aug 30, 2024

LHerskind Aug 30, 2024

Maddiaa0 Aug 30, 2024

Maddiaa0 Aug 30, 2024

Maddiaa0 Aug 30, 2024

LHerskind Aug 30, 2024

Maddiaa0 Aug 30, 2024

LHerskind Aug 30, 2024

Maddiaa0 Aug 30, 2024

LHerskind Aug 30, 2024

feat: Removing is_dev_net flag #8275

feat: Removing is_dev_net flag #8275

Conversation

LHerskind commented Aug 29, 2024 • edited Loading

Graveyard

LHerskind commented Aug 29, 2024 • edited Loading

AztecBot commented Aug 30, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LHerskind commented Aug 30, 2024

Maddiaa0 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

feat: Removing `is_dev_net` flag #8275

feat: Removing `is_dev_net` flag #8275

LHerskind commented Aug 29, 2024 •

edited

Loading

LHerskind commented Aug 29, 2024 •

edited

Loading

AztecBot commented Aug 30, 2024 •

edited

Loading